Thread: strstr: code & errors

Why oh why didn't you just reply to your other thread?

Code:

char str[]="good"; //Variable
char input1;  // So the user can only input 1 character? 

{//Why is this here? 
cout<< "Hello, how are you today?\n"<< endl;                     
getline(cin); /*So you are going to get it from the cin and put it where? */ 

char * pch;
pch=strstr (input1, 'good'); //Searching for “good” in  ^ Char str

//expression should be: if (pch != NULL )
if(char str[] !=null) // or perhaps “zero” instead of “null”? or just “str” instead of whole tag…

cout<< "I am glad to hear you are doing well today."<< endl;                      
else
cout<< "Is anything wrong at all? Would you like to discuss it? \n"<< endl;

the way you have input1 declared it can only store 1 character. If you need to store more then one character you need to have an array of characters.

reRanger, some of your code uses functions meant for the C++ string class in the header <string>. Other parts of the code use C-style strings, which are just null terminated character arrays. Pick one and stick to it so we can help you figure out how to fix your code.

I'd recommend the C++ string class, but if you have an instructor that is teaching you C-style strings then you might have to do it that way. Let us know which you'd prefer using.

PS. Change “ to " not '

C style strings are valid in C++ and are used often, but since you are doing this on your own I think it is good that you learn the C++ string class. Here is a simple program that uses that class.

Code:

#include <iostream>
#include <string>

int main()
{
    std::string input;
    std::getline(std::cin, input);

    if (input == "hello")
        std::cout << "You said hello." << std::endl;
    else
        std::cout << "You didn't say hello." << std::endl;

    if (input.find("ell") != input.end())
        std::cout << "The word ell was in your input." << std::endl;
    else
        std::cout << "The word ell was NOT in your input." << std::endl;
}

It is very difficult to code without a compiler in front of you. It is recommended that you first figure out the logical flow of the program (no computer or compiler needed). Then write the code for small parts of the program at a time. After each little bit you write, compile it and fix any compiler errors. If you can, test the incomplete code as you go, so that you know that what you have already written is working.

If you are trying to code without a compiler in front of you, you end up with a large program with tons of errors in it and it is harder to fix your problems. So I'd recommend finding out how to work your computer lab's compiler or just write out the logical flow of your program and wait until you get home to code it.

string is a type (like int or char).

input is the name of a variable that has a type string.

getline is a function that gets a line from an input stream and puts it into a string.

cin is the console input stream.

So the first line declares a string variable named input. The second line reads from the console a line of text and stores that line of text in the variable named input.

You can pretty much ignore the std:: part. All the names of functions, types, variables, etc, used in the standard library have a namespace so there are no naming conflicts. You don't really need to understand that now. You can put using namesapce std; like you did in your original code instead.