Thread: he we go again

EDIT: this post is unclear...please skim it and move on to the next

given by teacher......causes run time error...who would have guessed?......

please help...

Code:

//....
asset * * group = new asset * [count];
//..........
group[i] = new stock; break;  //stock inherits from asset
//^^ times 3
//.............
for(int j = 0; j < count; j++)
{
	delete group[j];
}
delete [] group;

Uhh... This what you're looking for?

Code:

asset** group = new asset*[count];
for(int i = 0; i != count; ++i)
   group[i] = new stock( ... whatever ... );

... Lalalala ...

for(int j = 0; j != count; ++j)
   delete group[j];
delete[] group;

Originally Posted by Zach L.

Uhh... This what you're looking for?

Code:

asset** group = new asset*[count];
for(int i = 0; i != count; ++i)
   group[i] = new stock( ... whatever ... );

... Lalalala ...

for(int j = 0; j != count; ++j)
   delete group[j];
delete[] group;

uhhh, no......

this is what's given..

Code:

#include <fstream.h>

#include "asset.h"
#include "stock.h"
#include "savings.h"
#include "property.h"

void main()
{
	int count;
	cout << "How any assets do you wish to enter? ";
	cin >> count;
	asset * * group = new asset * [count];
	
	for(int i = 0; i < count; i++)
	{
		char choice;
		cout << "What do you want s, v, or p? ";
		cin >> choice;
		switch(choice)
		{
			case 's': group[i] = new stock; break;
			case 'p': group[i] = new property; break;
			case 'v': group[i] = new savings; break;
		}

		group[i]->kinput();
		group[i]->print(cout);
	}

          for(int j = 0; j < count; j++)
	{
		delete group[j];
	}
	delete [] group;
}

i can't believe how bad of a teacher she is....it's horrible...i want my money back....hell, i should get paid....i'm constantly fixing her mistakes; in class, on projects, things she told other students....seriously...she-...ahhh!.....

if she gives us code, it better damn well work...but it doesn't....it never does.....it's not like she does it as a learning experience....she just doesn't know anything about what she's "teaching".....

if i didn't already know most of this stuff i would go to the school and demand my money back.....horrible!...absolutely horrible!

...now that i look back at it i see how you misunderstood my question, zach....

i was just trying to save some space.....

p.s. mods-not bumping posts....(look at time)

It doesn't work right because there isn't a default case in the switch statement, so your pointer will be invalid when acessing kinput() and/or print().

So...

Code:

void main()
{
.....................
        switch(choice)
        {
            case 's': group[i] = new stock; break;
            case 'p': group[i] = new property; break;
            case 'v': group[i] = new savings; break;
            default: group[i] = NULL; continue;
        }

        group[i]->kinput();
        group[i]->print(cout);
    }

    for(int j = 0; j < count; j++)
    {
        if(group[j])
            delete group[j];
    }
    delete [] group;
}

EDIT: I noticed now... Indeed an excelent teacher. void main() to power! Shoudn't there be a fflush(stdin);??

Yep... That'd do it.
Also note that there are two problems in the first eight lines. I think you'll catch them quickly, though.

*edit*
A test to see if 'count' is a valid positive integer would not be a bad thing either.

This teacher is rather questionnable.

i'm being about as clear as my teacher is.......

the problem is when it reaches the delete loop...

if i comment out the loop the programs completes "successfully"...that is, it doesn't throw a run-time error....

i did add the line: if(group[j])
and i did change it to int main....oh yea...i also added the default case for safe measures (i was entering the correct values)...

i just thought of something while typing this......what's the correct way to delete a string such as the following?
char *name = new char[strlen("test") + 1];

Well even if the teacher is giving "broken" code to let the students(not kids) learn something it should at least conform to the standard, come on void main? I can let old header files slide but not void main

Originally Posted by jwenting

Consider that your teacher might deliberately give you code which requires some thinking on your part to get it working.

That's what I'd do were I teaching class. Not always, but some of the time. I'd probably tell you though that there's something wrong so you'd not be as confused.

Good way to get kids to think rather than copy answers verbatim from a source book, though it doesn't seem to work anymore with kids refusing to think and rather post their entire assignment on some website where they'll then shout foul when noone gives them a complete perfect solution in 10 seconds...

yes, i understand that broken code is a good learning experience but a. she should warn us and b. it's not intentional. she REALLY does not know what she is doing. i can honestly say that i think i know more about the language than she does. i am certainly no guru either. i'm not saying she is a bad teacher because i can't keep up with her and i'm frustrated. i'm saying it because i've been doing c++ longer than anyone else in my class and i understand c++ quite well and i'm just amazed at some of the things she will tell them....there's so many things she says that are blatantly wrong. i eventually just quit correcting her.

I copied and pasted the code, replaced the classes with dummies (A,B,C inherit from D), and ran it. It didn't crash on me...

Take a look into the headers' code, the problem's probably there.

As a side note, I don't see why you need fstream in there. If anything, you'd be needing iostream...