C++ Style Question

I'm pontificating over this. Which is better?

This:

Code:

---

  if ( r > 0.0 &&
    pGraphType != gtBarChart &&
    pGraphType != gtHistogram )
  {...

---

or this:

Code:

---

  if ( r > 0.0
    && pGraphType != gtBarChart
    && pGraphType != gtHistogram )
  {...

---

Is there an accepted style for this? Or does it not matter?

Greetings Davros,

> I'm pontificating over this. Which is better?
» It all depends on which helps you read better. For instance, lets break this down.

Which of the following statements help better the understanding when reading:

Code:

---

if r is greater than 0.0 and
pGraphType does not equal gtBarChart and
pGraphType does not equal gtHistogram
then...

---

Or:

Code:

---

if r is greater than 0.0
and pGraphType does not equal gtBarChart
and pGraphType does not equal gtHistogram
then...

---

Note: Take a 2 to 3 second break after reading each line. This may help you find your style of how you like to read your code.

> Is there an accepted style for this? Or does it not matter?
» It does not matter. Either way we express it, it always means the same. Some programmers adapt to Example 1 or Example 2 when reading code. Which ever way you read code best should depict how you like seeing code.


- Stack Overflow

I don't think there's any accepted style. But I have to say, I like the second one better because:
a) You can clearly see that the logical operator is an AND
b) The &&'s are lined up
c) The indent from the &&'s causes the 3 conditions to line up perfectly

On the other hand, what do you do if you have:

Code:

---

if(r < 0.0 && (fooo || ((!foo || bar) && baar)) && foooo == baaar)
{
  //...
}

---

Would you do this:

Code:

---

if(r < 0.0 && (
      fooo || (
        (!foo || bar) &&
        baar
      )
  ) &&
  foooo == baaar)
{
  //...
}

---

:D

I'm fond of the first myself, though I indent so that the conditions line up.

Thanks

Most programmers will look to the end of the line for the operator.

Quote:

---

C Elements of Style

This example brings up another question: Do you put operators at the end of the line, as in the previous example, or at the beginning of the next line?

Actually, either method is acceptable as long as it is used consistently. That means that I don't get to dodge the issue if there is any reasonable basis for choosing one method over the other.

There is a basis: majority rule. Most programmers prefer to put the operators at the end of the line. So let's go with the majority preference and make it the rule:

When writing multi-line statements, put the arithmetic and logical operators at the end of each line.

---

The online book is well worth a read.

i like the second one beacuse in the first one you have a sentence and then you use 'AND' but then you start a new line so it is kind of confusing.

I'm a fan of the first version. Not least because I write in a variety of programming languages, and not all have statement terminators. In those languages, it can be vital to have an unsatisfied operator before the linebreak. (I think the language where this is so is called Mosel.)