Thread: Stupid Menus!!!

I just can't get this menu to work!!!

Code:

#include <iostream>

using namespace std;

int Menu(int pick);
int NewGame();
int Online();
int Quit();

int main()
{
    int pick=0;
    
    if (pick==0)
    cout<<Menu(pick);  
    if (pick==1)       
    cout<<NewGame();   
    if (pick==2)
    cout<<Online();     
    if (pick==3)
    cout<<Quit();   
}

int Menu(int pick)
{
    cout<<"Welcome to SUPER GAME! \n";
    cout<<"What Would You Like To Do: \n";
    cout<<"1. New Game \n";
    cout<<"2. Online \n";
    cout<<"3. Exit \n";
    cin>>pick;
    cout<<main();
}               

int NewGame()
{
    int pick;
    
    cout<<"This Game Is Currently Under Construction! \n";
    cin.get();
    cout<<Menu(pick);
}

int Online()
{   
    int pick;
    
    cout<<"No Such Feature Currently Available! \n";
    cin.get();
    cout<<Menu(pick); 
}

int Quit()
{
    return 0;
}

What I want it to do is it will go to the menu right? well then I want it to ask for the user to enter 1, 2, or 3 and then it will go back to MAIN. It will locate the correct function and go to it. But it will just go right back to the MENU. So this is what appears on the prompt.

Welcome to SUPER GAME!
What Would You Like To Do:
1. New Game
2. Online
3. Quit
X (whatever number 1-3)

Welcome to SUPER GAME!
What Would You Like To Do:
1. New Game
2. Online
3. Quit
X (whatever number 1-3)

It just continues to repeat itself. Anybody know how I could make it stop doing that?

Now I tried switching the int pick=0; up top where i state the prototypes but that doesn't work either. Anyone know what to do?

Fixed what you said to...program don't work any more X_X

Going back to my old code anybody got a clue?

Originally Posted by xviddivxoggmp3

why do you

Code:

cout<<menu();

??? this is not a valid function call, unless something has changed in the language lately.

thats totally valid. It will print the return value of menu(). (though it should have a capital 'M')

@OP: Your calling main() in your menu function.... dont do that.

So are you sayin, if I switch all those "if" statements to Menu and get rid of the calling of Main, it should work? Is main like, supposed to be just the starting point, which branches off to menu, and never go back to it?

Oh lol well in that case I'll just leave the code how it is and go onto the next lesson (switches) thanx

OK, I read the next tutorial and did the switches. I got it to work IF MainMenu didn't go back to main. Well this is the code:

Code:

#include <iostream>

using namespace std;

int MainMenu(int pick);
int NewGame();
int Online();
int Exit();
int pick;

int main()
{
    cout<<MainMenu(pick);     
}

int MainMenu(int pick)
{
       
    cout<<"Welcome to Super Game 2! \n";
    cout<<"1. New Game \n";
    cout<<"2. Online \n";
    cout<<"3. Exit \n";
    cout<<"Make A Selection: ";
    cin>>pick;
    switch (pick)
    {
        case 1:
            cout<<NewGame();
            break;
        case 2:
            cout<<Online();
            break;
        case 3:
            cout<<Exit();
            break; 
    }    
}

int NewGame()
{
    int pick;
    
    cout<<"Sorry, Not Available In This Version! \n";
    cin.get();
    cout<<main();
}

int Online()
{
    int pick;
    
    cout<<"Sorry, Not Available In This Version! \n";
    cin.get();
    cout<<main();
}

int Exit()
{
    cin.ignore();
    cout<<"Thanks For Playing!";
    cin.get();
}

Now what I want is the code to have MainMenu not have the switch statement. I want it so that Main has the switch statement and once you pick your variable at the MainMenu, it goes to Main and sees which case fits the variable pick. This is the code I messed around with:

Code:

#include <iostream>

using namespace std;

int MainMenu(int pick);
int NewGame();
int Online();
int Exit();
int pick;

int main()
{
      switch (pick)
    {
        case 1:
            cout<<NewGame();
            break;
        case 2:
            cout<<Online();
            break;
        case 3:
            cout<<Exit();
            break;
        default:
            cout<<MainMenu(pick);
            break; 
    }        
}

int MainMenu(int pick)
{
       
    cout<<"Welcome to Super Game 2! \n";
    cout<<"1. New Game \n";
    cout<<"2. Online \n";
    cout<<"3. Exit \n";
    cout<<"Make A Selection: ";
    cin>>pick;
    cout<<main(); 
}

int NewGame()
{
    int pick;
    
    cout<<"Sorry, Not Available In This Version! \n";
    cin.get();
    cout<<main();
}

int Online()
{
    int pick;
    
    cout<<"Sorry, Not Available In This Version! \n";
    cin.get();
    cout<<main();
}

int Exit()
{
    cin.ignore();
    cout<<"Thanks For Playing!";
    cin.get();
}

That code, makes the mainmenu appear every single time. No matter what number you press! It could be 9 billion and it would still go to the main menu! Anybody know how to fix it?

Here, try this. It should work for you.

Code:

#include <iostream>

using namespace std;

//Function prototypes...
void NewGame();
void Online();
void Exit();

//Function declaration...
void NewGame()
{
	cout << "Sorry, not available in this version!\n";
	cin.get();
}

void Online()
{
	cout << "Sorry, not available in this version!\n";
	cin.get();
}

void Exit()
{
	cout << "Thanks for playing!\n";
	cin.get();
}

int main()
{
	int pick;
	int done = 0;
	while(done == 0)
	{
		pick = 0;
		cout << "Welcome to Super Game 2!\n";
		cout << "1. New game\n";
		cout << "2. Online\n";
		cout << "3. Exit\n";
		cout << "Make a selection:\t";
		cin >> pick;
		switch(pick)
		{
		case 1:
			NewGame();
			break;
		case 2:
			Online();
			break;
		case 3:
			Exit();
			done = 1;
			break;
		}
	}
	return 0;
}

There are a few things you might want to note about this. Firstly, the functions; they were supposed to return an integer, but they didn't return anything. If you aren't returning a value, you should declare it as "void FunctionName()".

Next; the way you're calling the functions. Instead of calling them by using "cout<<FunctionName()", just use the function name (if it returns a value, say, an integer, use this; "int value = FunctionName()").

Now, when you call switch(), you used 'pick', which you declared earlier. However, you didn't assign a value to 'pick', so it goes straight to the default statement (as it didn't match any of the cases).

Also, you keep calling main() to run the process again. The main() function should only need to appear once in a program, and that's when you declare it. The computer knows what to do with it.

Instead, you should use a while loop. That'll loop through the process of asking for the user input, and then decide what to do with it.

Hope that helps.