Thread: Closing program

Code:

    
   char name[50];
    char exit;

    cout << "Please enter you name for the High Scores list : ";
  
    cin.getline(name, 50);
    ofstream WriteFileScore("HiScores.txt");

    if(!WriteFileScore.is_open())
    {                        //The file did not open
        cout << "Error Opening HiScores.txt.";
        exit = getch();
        
    }    
    else    
    {
        WriteFileScore << player.score;
        WriteFileScore.close();    
    }    
    
    ofstream WriteFileName("HiScoreNames.txt");
    
    if(!WriteFileName.is_open())
    {                        //The file did not open
        cout << "Error Opening HiScoreNames.txt.";
        exit = getch();
    } 
    
    else
    {
        WriteFileName << name;
        WriteFileName.close();
    }

After I type in the my name, the program just closes. I have tried a system("pause") and tried asking for input and it still close for some reason.
Thanks for any help.

1) The whole program is very large so I just gave the function.
2) Not sure, but why should it close? Is it the WriteFileScore.close() function?
3) The block of code I posted in my first post just closed without making the file (in case you were wondering). Code block A. works fine as its own program, but it wont work with the big program I am doing. Code block B. is the complete function that I tried to use in my program. Block B. is just code block A., but instead of using the int "score", it uses "player.score". Code block B. gives the same problem as the first block of code i posted.
Thanks

A

Code:

#include <iostream>
#include <fstream>
#include <conio2.h>    
    
using namespace std;
    
int main()
{    
    char name[50];
    char exit;
    int score = 10;

    cout << "Please enter you name for the High Scores list : ";
  
    cin.getline(name, 50);
    ofstream WriteFileScore("HiScores.txt");

    if(!WriteFileScore.is_open())
    {                        //The file did not open
        cout << "Error Opening HiScores.txt.";
        exit = getch();
        system("Pause");
        
    }    
    else    
    {
        WriteFileScore << score;
        WriteFileScore.close();    
    }    
    
    ofstream WriteFileName("HiScoreNames.txt");
    
    if(!WriteFileName.is_open())
    {                        //The file did not open
        cout << "Error Opening HiScoreNames.txt.";
        exit = getch();
        system("Pause");
    } 
    
    else
    {
        WriteFileName << name;
        WriteFileName.close();
    }
}

B.

Code:

void HiScores()
{
    
    char name[50];
    char exit;

    cout << "Please enter you name for the High Scores list : ";
  
    cin.getline(name, 50);
    ofstream WriteFileScore("HiScores.txt");

    if(!WriteFileScore.is_open())
    {                        //The file did not open
        cout << "Error Opening HiScores.txt.";
        exit = getch();
        system("Pause");
        
    }    
    else    
    {
        WriteFileScore << player.score;
        WriteFileScore.close();    
    }    
    
    ofstream WriteFileName("HiScoreNames.txt");
    
    if(!WriteFileName.is_open())
    {                        //The file did not open
        cout << "Error Opening HiScoreNames.txt.";
        exit = getch();
        system("Pause");
    } 
    
    else
    {
        WriteFileName << name;
        WriteFileName.close();
    }
       
}

that may be the scope of the player class, or it may be how you have the access modifiers set up... either way you'd be better passing that in as an parameter...

Code:

playerClass player;
...
HiScores(player.getscore());
...

Code:

void HiScores(int PlayerScore)
{
    
    char name[50];
    char exit;

    cout << "Please enter you name for the High Scores list : ";
  
    cin.getline(name, 50);
    ofstream WriteFileScore("HiScores.txt");

    if(!WriteFileScore.is_open())
    {                        //The file did not open
        cout << "Error Opening HiScores.txt.";
        exit = getch();
        system("Pause");
        
    }    
    else    
    {
        WriteFileScore << PlayerScore;
        WriteFileScore.close();    
    }    
    
    ofstream WriteFileName("HiScoreNames.txt");
    
    if(!WriteFileName.is_open())
    {                        //The file did not open
        cout << "Error Opening HiScoreNames.txt.";
        exit = getch();
        system("Pause");
    } 
    
    else
    {
        WriteFileName << name;
        WriteFileName.close();
    }
       
}

if you're wondering, to access that data member, your object should look something like this:

Code:

class playerClass
{
    public:
        int getScore() { return score; }
    private:
        int score;
};

then call player.getScore() if you want to find out the score... you should never be able to directly access data members... if you want to be able to modify the score, create a method called setScore(int) in the public section and have that modify the private member...

I still dont understand why it should close...

Code:

WriteFileName.close();

all that does is close the file you are working with,

For opening the file i could be wrong
but the reason your file isnt being created i believe
is because you never actually opened the file.

Code:

ofstream WriteFileScore("HiScores.txt");

should be

Code:

ofstream WriteFileScore;
WriteFileScore.open("HiScores.txt", ios::out);

or even :

ofstream WriteFileScore;
WriteFileScore.open("HiScores.txt");