Thread: Templated List errors with Insert

I'm writing a List Class for use in a school project (it's not due in a week or two, not monday) and when I use it to insert an item, the program crashes. I have an idea of what is wrong, but I'm not sure what to do; I just can't see how to fix it.

I believe the problem is with the constructor and/or the insert function. The problem is that it is trying to insert an item at an invalid point in the list. I will post the few functions, if you need to see the whole project, I will post it.

Code:

template <class T>
bool List<T>::isEmpty()
{
	return numItems == -1;
}

template <class T>
bool List<T>::isFull()
{
	return numItems == MAXSIZE;
}

template <class T>
bool List<T>::isValidPos(int n)
{
	if ((n >= 0) && (n < numItems))
		return true;
	//if ((n > numItems) || (n < 1))
	//	return false;
	return false;
}

template <class T>
List<T>::List(int n):MAXSIZE(n)
{
	data = new T[MAXSIZE];
	numItems = 0;
	curpos = 0;
}

template <class T>
bool List<T>::insert(const T &r)
{
	if (isFull())
		return false;
	if (isValidPos())
	{
		for (int i=numItems; i>=curpos; i--)
			data[i+1] = data[i];
		data[curpos] = r;
		numItems++;
		return true;
	}
	return false;
}

Those are in the header file; this is how I use it in the driver.cpp file.

Code:

int main()
{
	List<int> a(10);
	a.insert(1);
	a.insert(2);
	int tmp;
	a.getData(tmp);
	cout << tmp << endl;
	a.next();
	a.getData(tmp);
	cout << tmp << endl;
	return 0;
}

Thanks for help, but please don't post code.

Originally Posted by kuphryn

First off, make sure list container has space for a new item.

Second, modify your code.

// numItems is already the next index

for (int i = numItems; i >= curpos; --i)
data[i] = data[i];

Kuphryn

By check for space do you mean check if the list is full, because I have the function isFull() checked, and I also check if the position is valid. What am I supposed to be modifying in that code? Do you mean to check if there's space?


I forgot to tell main elements in the class.

Code:

template <class T>
class List
{
	private:
		T *data;
		int numItems, curpos;
		const int MAXSIZE;

Alright, I've changed the code so that numItems is one past the last as suggested. I still get the same problems. I'm not seeing why this won't work.

Code:

template <class T>
List<T>::List(int n):MAXSIZE(n)
{
	data = new T[MAXSIZE];
	numItems = 0;
	curpos = 1;
}

template <class T>
bool List<T>::isEmpty()
{
	return numItems == 0;
}

template <class T>
bool List<T>::isFull()
{
	return numItems == MAXSIZE;
}

template <class T>
bool List<T>::isValidPos(int n)
{
	return ((n >= 0) && (n < numItems));
}
template <class T>
bool List<T>::insert(const T &r)
{
	if (isFull())
		return false;
	for (int i=numItems; i>curpos; i--)
		data[i] = data[i-1];
	data[curpos] = r;
	numItems++;
	return true;
}

template <class T>
bool List<T>::remove()
{
	if (isEmpty())
		return false;
	for (int i=curpos; i<numItems; i++)
		data[i] = data[i+1];
	numItems--;
	return true;
}

template <class T>
bool List<T>::getData(T &r)
{
	if (!isValidPos() && !isEmpty())
	{
		r = data[curpos];
		return true;
	}
	return false;
}

template <class T>
bool List<T>::next()
{
	if (curpos == (numItems-1))
		return false;
	curpos++;
	return true;
}

I did as you suggested, and even have code from a list and corrected a few numbers, but the same thing still happens. Am I initializing it ok? argh.

Here's how I use it in main:

Code:

int main()
{
	List<int> a(10);
	a.insert(1);
	a.insert(2);
	int tmp;
	a.getData(tmp);
	cout << tmp << endl;
	a.next();
	a.getData(tmp);
	cout << tmp << endl;
	return 0;
}

Sorry for all the long code. If someone is willing to look at the whole thing (in case the problem is not in what I've posted, but I'm pretty sure it's there) I can email it to them or post it here. Thanks for the help too.

OMFG. OMFG. Error was in a completely different place. Go figure. Thank you so much elad. It got me thinking a bit more. Decided to test the getData(), 'cause the data getting printed was some sort of address; orriginally I thought to be because insert failed. Turns out my getData() was bailing out because I had !isValidPos(). damn damn damn.
:::smacks palm on forehead <-- programmer's high five:::
Wow, I really appreciate the help, and going through the trouble of not using code. Thanks alot guys.