trying to remove item from an array

**rugger78** · 10-14-2004

this is a function that should remove an integer from an array but when i run it, it will remove the integer but the array will remain the same size. do i have an error im not seeing.

Code:

    // Method that takes an int from the bag making it one size  smaller 
   // int refers to its location in memory using a zero index 
   void Bag::take(int location) 
   { 
      cout<<"TAKING" << endl; 
      int new_maxsize = maxsize - 1; 
      int *temp_array = new int[new_maxsize]; 
      int second_half = location + 1; 
      for (int index = 0; index < location; index++) 
      { 
         temp_array[index] = p[index]; 
      } 
      for (int index = location; index < new_maxsize; index++) 
      { 
         temp_array[index] = p[second_half]; 
         second_half++; 
      } 
      
      maxsize = new_maxsize; 
      p = temp_array; 
      currentloc = new_maxsize; 
      
   }

**jverkoey** · 10-14-2004

Just don't change the maxsize variable if you want it to be the same size.

vvvvv Get rid of this vvvv
int new_maxsize = maxsize - 1;

**alphaoide** · 10-14-2004

Code:

p = temp_array;   // memory leak??

If 'p' is a pointer to A = int[old_size], and now 'p' points to B = int[new_size], what happens with A?

**rugger78** · 10-14-2004

im sorry i mistyped i want the array to get resized but it does not

**rugger78** · 10-14-2004

i have a destructor that gets rid of 'A'

**alphaoide** · 10-14-2004

'maxsize' does change, does it not?
Don't tell me you get the size of array by doing this.

Code:

// if p is defined as: int * p = new int[ maxsize ];
// the following line will not display the size of array

cout << sizeof(p);

**Hunter2** · 10-15-2004

>>i have a destructor that gets rid of 'A'
That's irrelevant. The destructor will only free the last array that you created; all the others will be leaked.

Code:

delete[] p;   //Free the previously allocated array.
p = temp_array;

Thread: trying to remove item from an array

Thread Tools

Search Thread

Display

trying to remove item from an array

Similar Threads

Resource Management question..

Recursion Revisited again, and again!

instantiated from here: errors...

Unknown Memory Leak in Init() Function

Request for comments