Problem Filling Vector

This is a discussion on Problem Filling Vector within the C++ Programming forums, part of the General Programming Boards category; Hi. I am attempting to fill a vector with characters from a text file. I want to have the vector ...

  1. #1
    diligentStudent()
    Join Date
    Apr 2002
    Posts
    79

    Problem Filling Vector

    Hi. I am attempting to fill a vector with characters from a text file. I want to have the vector hold a dual object - a character and an integer count. I'm trying to fill the vector, but can't quite figure out how to do this. Here is an attempt below. Any ideas will be greatly apppreciated. Thanks.
    Code:
    #include<iostream>
    #include<fstream>
    #include<cstdlib>
    #include<vector>
    using namespace std;
    
    class Find
    {
      public:
        Find();
        void setChar(char chr);
        char getChar();
        void setCount(int ct);
        int getCount();
        void countAdd();
        friend ostream& operator <<(ostream& of, Find f)
        {
          of<<"Found "<<f.count<<" of "<<f.ch;
          return of;
        }
      private:
        char ch;
        int count;
    };
    
    int main(int argc, char* argv[])
    {
      ifstream in (argv[1]);
      char cz;
      vector <Find> v;
      Find f;
      while(in.get(cz))
      {
          for(int i=0; i<v.size(); i++)
          {
            if(v[i].getChar() == cz)
            {
              v[i].countAdd();
              break;
            }
            else
            {
              f.setChar(cz);
              f.setCount(1);
              v.push_back(f);
            }
         }
      }
      for(int i=0; i<v.size(); i++)
      {
        cout<<v[i]<<endl;
      }
      return 0;
    }
    
    Find::Find() : ch(0), count(0) {}
    
    void Find::setChar(char chr)
    {
      ch=chr;
    }
    
    char Find::getChar()
    {
      return ch;
    }
    
    void Find::setCount(int ct)
    {
      count=ct;
    }
    
    int Find::getCount()
    {
      return count;
    }
    
    void Find::countAdd()
    {
      count++;
    }

  2. #2
    Registered User
    Join Date
    Oct 2001
    Posts
    2,934
    I think you need to rework your logic slightly. Perhaps something like this.
    Code:
    int main(int argc, char* argv[])
    {
      ifstream in (argv[1]);
      char cz;
      vector <Find> v;
      Find f;
    
      while(in.get(cz))
      {
          bool found = false;
          for(int i=0; i<v.size(); i++)
          {
             if(v[i].getChar() == cz)
             {
                v[i].countAdd();
                found = true;
                break;
             }
          }
          if (!found)
          {
              f.setChar(cz);
              f.setCount(1);
              v.push_back(f);
           }
      }
      for(int i=0; i<v.size(); i++)
      {
        cout<<v[i]<<endl;
      }
      return 0;
    }

  3. #3
    Registered User jlou's Avatar
    Join Date
    Jul 2003
    Posts
    1,088
    You might want to consider learning about or using the std::map. You wouldn't have to do that for loop to search the vector, the map would find the char (if it was there) for you.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. Vector Addition Using OOP?
    By everydaybh in forum C++ Programming
    Replies: 3
    Last Post: 04-09-2009, 05:09 AM
  2. How can i made vectors measuring program in DevC++
    By flame82 in forum C Programming
    Replies: 1
    Last Post: 05-07-2008, 02:05 PM
  3. Vector problem
    By swgh in forum C++ Programming
    Replies: 2
    Last Post: 11-06-2007, 11:41 AM
  4. syntax help?
    By scoobygoo in forum C++ Programming
    Replies: 1
    Last Post: 08-07-2007, 10:38 AM
  5. vector problem with erase()
    By JukeBoxHero in forum C++ Programming
    Replies: 5
    Last Post: 10-03-2006, 07:02 PM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21