Thread: getline() and ifstream

here is the deal, if you press enter, no prob, it waits for a filename, if you enter a bad filename, fin fails and it loops to ask for a valid filename, however, if you then enter a valid filename, it continues to loop regardless.

Here is the code:

Code:

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

int main()
{
	cout << "enter filename: ";
	string filename;
	getline(cin, filename);
	
	while (filename.empty()) getline(cin, filename);
	
	ifstream fin(filename.c_str());

	while (fin.fail())
	{
		cout << "ERROR: enter filename: ";
		getline(cin, filename);
		
		while (filename.empty()) getline(cin, filename);

		ifstream fin(filename.c_str());
	}
	return 0;
}

I think the problem is that fin does not get rediefined, but i am not sure how to get around it. Thanks

-quizkiwi

You are declaring two different variables called fin. The first one is in the main scope of the main function. The second one is inside the scope of the while loop. The fin.fail() call is only testing the one created in the outside scope, which doesn't change.

I'd suggest using the open function instead of trying to use the constructor to open the file. You can pass it the filename just as you do the constructor. Also remember to clear any fail bits if the open fails.

do i have to write something to the file? as in:

Code:

myfile << "test";
  if (myfile.fail())
  {
    cout << "Error writing to test.txt\n";
    myfile.clear();
  }

Will this not overwrite the information on the file?

You can use is_open instead of fail() or good().

okay, i will give that a whirl, thanks