Problem with this code

Hi, can anyone explain why this crashes at the delete part?

char *args[1000];

args[0] = new char[10];

delete [] args[0];

Thanks.

I think the first line is creating a pointer to an array of 1000 chars, as opposed to an array of 1000 char pointers. Add these brackets:

Code:

---

char (*args)[1000];

---

I think, but I'm not too sure.

you should use the delete keyword whenever you create new memory....


Not sure if this is what you are trying to do.. .but here is an example of how you would create a dynamic array... and then properly delete it.

Code:

---

#include<iostream>

using namespace std;

int main()
{

    int capacity;

    cout << "Enter the size of the array: ";

    cin >> capacity;


    //create a dynamic array based on user input

    char *args;

    args = new char[capacity];

    //At this point, you can manipulate the args[] dynamic array size and content as you wish


    //When you are done with args[], you should delete this newly allocated memory

    delete [] args;

return 0;

}

---

As you can see.. with a dynamic array, you can adjust to the size of the array to meet the needs of your program... unlike a regular array which must be declared with a fixed number of elements :)

I'd post more code. The code that you did post compiled and ran for me.

this code, by itself, works fine:

Code:

---

        char *args[1000];
        args[0] = new char[10];
        delete [] args[0];

---

so there must be something else happening inbetween. some possible causes can be you overwrite the pointer stored at args[0] and then delete the new pointer, or your code manages to delete args[0] more than once. a common mistake is to say args[0] = someotherstring; in an attempt to copy a string, but this will only copy the pointer to the string, and thus, when you try to delete args[0], it's really trying to delete 'someotherstring.' if this is your problem, use strcpy() or memcpy() or some string copying routine instead of the = operator.

Try this when you delete.

Code:

---

if(args[0] != NULL)
    delete [] args[0]

---

Ive actually had a problem where it tries to delete whts not there and crashes

Quote:

---

Originally Posted by Vicious

Try this when you delete.

Code:

---

if(args[0] != NULL)
    delete [] args[0]

---

Ive actually had a problem where it tries to delete whts not there and crashes

---

No!
The C++ language guarantees that delete p will do nothing if p is equal to NULL. Since you might get the test backwards, and since most testing methodologies force you to explicitly test every branch point, you should not put in the redundant if test.

Wrong:

Code:

---

if (p != NULL)
  delete p;

---

Right:

Code:

---

delete p;

---

source: http://www.parashift.com/c++-faq-lit....html#faq-16.7

Hi, thanks for the help. I think I found the problem. I had

args[argnum] = new char[sizeof(superbuffer) + 1];

I think I meant strlen(superbuffer).

I read in deitel and deitel I think that you should set the pointer to null after deletion. Is my memory failing or is there some valid reason for doing this.

Unless the pointer goes out of scope immediately after you delete it, the reason for setting it to null is so that if any other code tries to delete it again it will not crash, and any code that checks for a null pointer will not crash when trying to use it after you delete it.

In general your code should be smart of enough not to use deleted pointers, but there are some cases when you don't know one way or another, and so setting it to null tells you.