Thread: reading and spliting a string

> I'm getting compiling errors.
How about posting the code you have so far?

i'm using this code...it's working but giving runtime failure..."stack around 'par' is correpted..
can somebudy tell me it's solution.
thanks
nj

Code:

#include "stdafx.h"
#include  <fstream>
#include  <iostream>
#include <string>
using namespace std;


int _tmain(int argc, _TCHAR* argv[])
{
	char buffer[100];
	char* st;
	float par[30][4],st1;
	int i=0, j;
    ifstream infile("test.dat");

	while(infile) 
	{ 
	  j=0;
      infile.getline(buffer,100);
	  st = strtok(buffer,",");
         while (st != NULL)
	     {
		  st1=atof(st);
          par[i][j]=st1;
		  //cout << par[i][j] << "\t";
		  j++;
	      st = strtok(NULL,",");
	      //cout <<"\t" ;
	     }
      i++;
	}

	for(int a=0; a<30;a++)
	{
		for(int b=0; b<4; b++)
	   {
	   cout << par[a][b] << "\t";
	   }
       cout << "\n" ; 
	}
 	return 0;
}

That looks pretty dangerous if the data file doesn't have 30 lines with 4 items each. You need to make sure that i and j don't exceed the boundaries of the array when inputting your data.

A couple of points
1) change your editor to use only spaces for indentation. Random mixes of spaces and tabs may look OK on your screen, but generally look a mess when viewed everywhere else.

2) Don't forget the code tags when you post. See the "read this first" at the top of each forum.

3) st and st1 are really horrible names. Tells me nothing about what you are doing

4) Your outermost loop should be
while ( infile.getline(buffer,100) )

5) You may as well save a temporary with
par[i][j]=atof(st);