text file

can anyone tell me why there is 18 numbers in the text file instead of 10. thanks

Code:

---

#include <fstream>
#include <iostream>
#include <cstdlib>
#include <ctime>

using namespace std;


void rand_seed()
{
int seed = static_cast<int>(time(0));
srand(seed);
}


int rand_int(int a, int b)
{
        return a + rand() % (b - a + 1);
}

       

int main()
{
        int response;
       
                      do
               
                              {                               
                cout<<"Enter 1 for a list 2 to exit.";       
                cin>>response;                                                       
                  if (response == 1)
               
                                {
                       
                          rand_seed();
                                ofstream fout;
                                fout.open("data.dat", ios::out);
       

                int arr [10];
                rand_seed();
                int i;                                       
                for (i = 1; i <= 9; i++)
               
                {               
                        int d1 = rand_int(1, 99);
                        arr[i] = d1;
                        fout<<arr[i];
                }
       
                fout.close();
                               
                }
                else
                cout<<"Thank you!!!";                               
                                while (response == 1);
               
 return 0;
}

---

> can anyone tell me why there is 18 numbers in the text file instead of 10.
Because your loop only outputs 9 numbers, not 10
So I guess you ran it twice without deleting the file.

FIRST

Code:

---

#include <fstream.h>
#include <iostream.h>
#include <cstdlib.h>
#include <ctime.h>

---

SECOND

Code:

---

for(i=0;i<9;i++)

---

....

Quote:

---

Originally Posted by enjoy

FIRST

Code:

---

#include <fstream.h>
#include <iostream.h>
#include <cstdlib.h>
#include <ctime.h>

---

....

---

Nope he was absolutely right with the headers he was using. Using fstream.h is not favorable as those headers are officially deprecated.

> #include <fstream.h>
No, this is old standard C++

#include <fstream>
Followed by
using namespace std;

Is the new way.

> for(i=0;i<9;i++)
Loops just as many times as
for(i=1;i<=9;i++)

Quote:

---

Originally Posted by enjoy

FIRST

Code:

---

#include <fstream.h>
#include <iostream.h>
#include <cstdlib.h>
#include <ctime.h>

---

SECOND

Code:

---

for(i=0;i<9;i++)

---

....

---

I'm not sure if you meant it, but both your suggestions are wrong.

The FIRST one says to use old, non-standard or deprecated headers. Not a good suggestion if bj31t is already using the newer headers.

The SECOND one still says to print out 9 numbers, even though it corrects the problem with starting at 0.


EDIT - :) Too Slow. And by the way, if I'm not mistaken, <iostream.h> and <fstream.h> are not deprecated, they are just old and non-standard. <stdlib.h> and <time.h> on the other hand are standard, but have been deprecated and with the newer headers being preferred.

Hehe...see that enjoy? Post something incorrect and you get 3 rebukes within the space of a minute! That's forums for ya!

Darn I was only a few minutes too late! I had to go to the bathroom...

Yea you're so wrong that I almost cried. Use the newer headers.

not all the compiler accept <fstrem> ===> so my compiler don't accept

i advice to you using

Code:

---

*arr[10];

---

to economise memory

You obviously don't know C++ because or else you would not be saying that. *arr[10] makes no sense for this program and won't economize any memory. His array code is perfectly fine and plus we're talking about 10 ints... 20-80 bytes, w00t.

Giving bad advice is not the way to go.

> not all the compiler accept <fstrem> ===> so my compiler don't accept
Your compiler is too old then - consider something which isn't TurboC++ for DOS.

> to economise memory
Which would be to not have the array in the first place.

> *arr[10];
You would have to initialise all those pointers some how, thus using up even more memory.

Quote:

---

Originally Posted by enjoy

not all the compiler accept <fstrem> ===> so my compiler don't accept

i advice to you using

Code:

---

*arr[10];

---

to economise memory

---

PLEASE stop posting until you learn more.

omg holy!!!! -bleep- SOMEONE PUT OUT THE FIRE!!!

Jesus you would think any of this matters..

He's obviously not asking for optimized code he's asking for a solution for his code..who cares what headers he's using? Even though <iostream> includes <fstream>...

thanks for the help!! i guess it would have helped if i had told you i was using c++.net. i dont think you have to use .h

Quote:

---

Originally Posted by Tronic

omg holy!!!! -bleep- SOMEONE PUT OUT THE FIRE!!!

Jesus you would think any of this matters..

He's obviously not asking for optimized code he's asking for a solution for his code..who cares what headers he's using? Even though <iostream> includes <fstream>...

---

The point was that one poster gave advice correcting the OP, but that was bad advice in the opinion of several of us. The fire didn't have to be so large, but since all three of us posted at roughly the same time, it came off worse than it was.

I hope you'd agree that it does matter when one poster incorrectly advises someone to change their code from right to wrong.

And by the way, <iostream> does not include <fstream>, at least not on most platforms.

-------

bj31t,

Did you figure out your for loop problem?

yes, i agree 100% that the posts should be correct. for inexperienced people like me it is very important. thanks for all the help!