boolean operators

Could someone tell me what is wrong with the boolean operators in this program
thanks!!

Code:

#include <iostream>
#include "test2.h"

using namespace std;



int main()
{

	
	double balance, chargeAmt,c,payAmt, bal,C ,P,D, Q;
	string trans;
	
	cout<<"Enter beginning balance. ";
	cout<<endl;
	cin>>balance;
	cout<<endl;
	
	if (cin.fail())
	{
		cout<<"ERROR! Bad Input!!";
		return 1;
	}

	cout<<"How can we be of service today?";
	cout<<endl;

	do 
	{

		cout<<"Enter transaction: (C, P, D, Q) ";
		cin>>trans;
		cout<<endl;
	}

	
	while (trans != Q);

	if(trans == C)	
	{
		cout<<"Amount of charge: ";
		cin>>chargeAmt;
		cout<<endl;
	
		bal = charge_amount(balance,chargeAmt);
		cout<<"Your new balance is "<<bal;
	}

	else if (trans == P)
	{	
		cout<<"Payment amount: ";
		cin>>payAmt;
		cout<<endl;
	
		bal = pay_amount(balance,payAmt);
		cout<<"Your new balance is "<<bal;
	}
	
	else if (trans == D)
	{
		cout<<"Your balance is "<<bal;
		cout<<endl;
	}


	else if (trans == Q)
	{
		cout<<"Good Bye!";
		cout<<endl;
	}
	
	else 
		cout<<"Enter valid input!";


return 0;
}

> while (trans != Q);
You mean apart from the fact that trans is an initialised string, and Q is an uninitialised double?

Perhaps you meant
while (trans != "Q" );

i had tried that but i got the same error:


binary '==' : std::string' does not define this operator or a conversion to a type acceptable to the predefined operator

Originally Posted by bj31t

i had tried that but i got the same error:


binary '==' : std::string' does not define this operator or a conversion to a type acceptable to the predefined operator

add #include <string> so you could make use of the overloaded operators.
I see that you could've declared trans as a char instead of a string.

OK I just looked over your code again, after misreading it the first time...

Your loop is kind of messed up. Ignoring syntax errors, what it does is display a prompt, then get user input. If the input isn't 'Q' for quit, then it displays the prompt again and inputs again, etc. until the user DOES enter 'Q'.

First, you don't need all those doubles called c, C, Q, P, D. I don't see why you have them declared, since you never use them.

Then, you need to stick all of the 'if' and 'else if' in the loop.

Ok, now that the program makes logical sense, you need to get the syntax right. Declare trans as a char instead of a string, for the sake of simplicity. Then C, P, D, Q need to have single quotes around them, otherwise they'll be interpreted as variables (which I suspect is why you have them declared as doubles - if the compiler spits out an error, don't randomly make changes and hope that it'll stop giving you errors, otherwise you'll just get bigger problems, like this. Take the time to figure out what's wrong.). The single quotes means to interpret it as a char.

Once you've done all this, I *think* it should work, although I'm not 100% sure because I didn't try it.

Hope this helps!

Thanks!!! That helped a lot.