Classe constructor and Vector question

I was wondering how to declare a vector into a constructor. Can someone kindly tell me where I am going wrong?

Code:

---

class WordRecord
{
public:

        WordRecord(vector<string> &vs, LineRecord * & pLineRec);

---

I am not sure about the declarations here:

Code:

---

WordRecord::WordRecord(vector<string> &vs, string *p)
{
        vectorString[i]= vs[i];
        *pLineRec = *p;
}

---

This is to create a new Word Record, which brings in a Line Record (I am also wondering if I am bringing in the Line Record properly):

Code:

---

  LineRecord * pLineRec;
  WordRecord * pWordRec;

  vector<string> vs[80];
  vs[i].push_back(line);

  pLineRec = new LineRecord(sentence, filename, lineNum);

  pWordRec = new WordRecord(vs[i], pLineRec);

---

In any case, I can't seem to be able to bring in the vector into the Word Record. I know it's because I can't declare my constructor properly. Any help would be much appreciated.

Code:

---

WordRecord::WordRecord(vector<string> &vs, string *p)
{
        vectorString[i]= vs[i];    // where is 'i' declared?
        *pLineRec = *p;
}

---

Oops, my bad. I cut too much out.

Code:

---

 
  LineRecord * pLineRec;
  WordRecord * pWordRec;

  vector<string> vs[80];
  vs[i].push_back(line);

  pLineRec = new LineRecord(sentence, filename, lineNum);

  pWordRec = new WordRecord(vs[i], pLineRec);

---

In any case that's where it is declared. It's used to insert words into the vector.

Code:

---

....
vector<string> vs[80];
vs[i].push_back(line);  // what is the current value of variable i?
                                      // where is it initialized?
....

---

Quote:

---

Originally Posted by stimpyzu

It's initialized in the same function and it's int i = 0.

---

How about i on this one?

Code:

---

WordRecord::WordRecord(vector<string> &vs, string *p)
{
        vectorString[i]= vs[i];    // where is 'i' declared?
        *pLineRec = *p;
}

---

In WordRecord::WordRecord

Could you just post entire code for class WordRecord?

That would make sense... but don't laugh, I'm new at classes :o

Code:

---

class WordRecord
{
public:

        static WordRecordIndex index;

        WordRecord();

        WordRecord(vector<string> &vs, LineRecord * & pLineRec);

        string find(WordRecord &key);

        bool operator >(const WordRecord & rhs) const;
        bool operator ==(const WordRecord & rhs) const;
        bool operator >=(const WordRecord & rhs) const {return ((*this) > rhs ) || ((*this) == rhs );}
        bool operator <(const WordRecord & rhs)  const {return !((*this) >= rhs );}
        bool operator <=(const WordRecord & rhs) const {return !((*this) > rhs );}
        bool operator !=(const WordRecord & rhs) const {return !((*this) == rhs );}
        friend ostream& operator << (ostream& ostr, const WordRecord& p);

 
private:

        vector<string> vs;
        string *pLineRec;


};

---

You probably need to post the implementation also, not just the declaration. Anyways..

Code:

---

private:
        vector<string> vs;  // if vs is class member then .... (cont'd)
        string *pLineRec;
};
......
WordRecord::WordRecord(vector<string> &vs, string *p)
{
        vectorString[i]= vs[i];    // what is vectorString?
        *pLineRec = *p;
}

---

You'll have to excuse me, I'm quite tired, I've been at this a long time....

Code:

---


#include "WordRecord.h"

WordRecordIndex WordRecord::index = byLineRec;


WordRecord::WordRecord()
{
        string key;

}

WordRecord::WordRecord(vector<string> &vs, string *p)
{
        int i;
        vs[i]= vs[i];
        *pLineRec = *p;
}


bool WordRecord::operator >(const WordRecord & rhs) const
{
        if(index == byLineRec)
        {
                return vs>rhs.vs;
        }
        else
        {
                assert(index == byLineRec);
                return pLineRec>rhs.pLineRec;
        }
}



bool WordRecord::operator ==(const WordRecord & rhs) const
{
        return (vs==rhs.vs)&&(pLineRec==rhs.pLineRec);
}

---

From your code above (I don't know if you copied right)

Code:

---

WordRecord::WordRecord(vector<string> &vs, string *p)
{
        int i;
        vs[i]= vs[i];
        *pLineRec = *p;
}

---

Variable i is never initialized
Your class member has same name as the parameter (vs[i]= vs[i];), I suggest fix that
What is this constructor supposed to do, copy a string in one vector to another? or?

Well actually, I've already tried it with

Code:

---

WordRecord::WordRecord(vector<string> &vs, string *p)
{
        vectorString= vs;
        *pLineRec = *p;
}

---

Where there was no variable to initialize, and that didn't work with the rest of the code either.


To tell you the truth, I'm trying to follow the same thing I did for the Line Record which worked well. But because of the vector, it's confusing me for the constructor, and I'm a little iffy on bringing in the LineRecord into the WordRecord.

Code:

---

//The Line Record Implementation seems to work ok
LineRecord::LineRecord(string s, string f, int l)
{
        sentence = s;
        filename = f;
        lineNum = l;
}

bool LineRecord::operator >(LineRecord & rhs)
{
        if(index == bySentence)
        {
                return sentence>rhs.sentence;
        }
        else
        {
                assert(index == byFile);
                return filename>rhs.filename;
        }
}

bool LineRecord::operator ==(LineRecord & rhs)
{
        return ((sentence==rhs.sentence)&&(filename==rhs.filename)&&(lineNum==rhs.lineNum));
}


ostream& operator << (ostream& ostr, const LineRecord& line)
{
        // a little example of C++ formated output
        ostr<<setiosflags(ios::left);
        ostr<<setw(10);
        ostr << line.sentence;
        ostr << line.filename;
        ostr<< " [";
        ostr << line.lineNum;
        ostr<< "]";

        return ostr;
}

---

The Word record will include a smilar ostream operator at the end once I've figured out how to declare the constructor.

Code:

---

//And the class works ok as well
class LineRecord
{
public:
        static LineRecordIndex index;

        LineRecord(string s,string f,int l);

        bool operator >(LineRecord & rhs);
        bool operator ==(LineRecord & rhs);
        bool operator >=(LineRecord & rhs) {return ((*this) > rhs ) || ((*this) == rhs );}
        bool operator <(LineRecord & rhs)  {return !((*this) >= rhs );}
        bool operator <=(LineRecord & rhs) {return !((*this) < rhs );}
        bool operator !=(LineRecord & rhs) {return !((*this) == rhs );}
        friend ostream& operator << (ostream& ostr, const LineRecord& p);

private:
        string sentence,filename;
        int lineNum;
};


ostream& operator << (ostream& ostr, const LineRecord& p);

---

As I've said, I'm using this Line Record code to guide me into doing the Word Record code

Code:

---

class WordRecord
{
public:
  WordRecord(vector<string> &vs);

private:
  vector<string> vs;        //be sure this is vectorString and not vs, as in your earlier posts
};

---

That being said I'd think this would work:

WordRecord::WordRecord(vector<string> & vs)
{
vectorString = vs;
}


Or you could use a copy constructor to initialize vecotrString with vs

WordRecord::WordRecord(vector<string> &vs) : vectorString(vs)
{}


Or you could use a loop, if you want

Code:

---

WordRecord::WordRecord(vector<string>& vs)
{
  int i;
  for(i = 0; i < vs.size(); ++i)
  {
      vectorString[i] = vs[i];
  }
}

---

Well, If this is what you mean:

Code:

---

public:
       
        WordRecord(vector<string> &vs, LineRecord * & pLineRec);
 
private:

        vector<string> vs;
        string *pLineRec;


};

---

Code:

---

WordRecord::WordRecord(vector<string> &vs, string *p)
{
        vectorString= vs;
        *pLineRec = *p;


}

---

I had tried it before (and just re-tried it again) but with no success :confused:


I don't know how I could use the copy constructor with the pLineRec, but I will give it a try. I have a feeling I'm going to be on this for a long while still... better get some coffee!!

Thanks for your input, I appreciate it!

He means this:

Code:

---

public:

    WordRecord(vector<string> &vs, LineRecord * & pLineRec);
 
private:

    vector<string> vectorString; 
    string *pLineRec;


};

---

Code:

---

WordRecord::WordRecord(vector<string> &vs, LineRecord *&p) // Cant use string
// here since you said it should be a LineRecord.
{
    vectorString= vs;
    *pLineRec = *p;


}

---

with your code you tried to assign everything that was in vs which is what you called a parameter to the constructor to the vs that was defined in your class. By doing that you are just begging for weird stuff to happend. I suggest you read up on functions and some basic programming stuff before you move on with classes.
Also that pointer to a reference or what it is in the constructor looks spooky but I dont know if that is valid or not.

Quote:

---

Also that pointer to a reference or what it is in the constructor looks spooky but I dont know if that is valid or not.

---

Depends on how it's interpreted... if it's a pointer-reference, it's valid and I use it all the time. On the other hand, if it's a reference-pointer, that *might* be problematic. Either way, you should use ( ) to make it clear which one it is.

(Object*)& obj

I don't know how you'd make it clear what you're doing if you want to do it the other way though, i.e.

Object &(*obj)
or
Object *(&obj)

Both are kind of iffy... like, a pointer to an Object&? or is it a reference to an Object *obj? Who knows, only the person that wrote the compiler or maybe Prelude ( :rolleyes: )

Thanks for the input, it is much appreciated but I've tried it that way, and I still get errors.

Quote:

---

Originally Posted by Shakti

I suggest you read up on functions and some basic programming stuff before you move on with classes.

---

I couldn't agree with you more, that's what I would like to do, but I have to do this program just the same with these specs on top of 4 other classes which are non programming related. I really wished I could only concentrate on C++ and nothing else, but unfortunately, I can't. I think it's crazy the way they show us how to program blindly, without much explanation or without any time to really learn the depth of the language.

Quote:

---

Originally Posted by Shakti

Also that pointer to a reference or what it is in the constructor looks spooky but I dont know if that is valid or not.

---

Well, I'm not sure that I'm going to need a pointer, but what I'm trying to do here is pass the wordrecord (that includes the vector and the linerecord) into a binary search tree so that when I search for a word (that can be found in the vector of the word record) it will return that word and the whole line record. I think I have my find word function working right, but I wont know until I can insert everything properly.

Needless to say, I am quite confused, and I've been working on this for countless hours. It is due tomorrow morning, but I need to study for a physics exam so I guess it may be a little late :rolleyes:

In any case, I will keep at it because I want and need to know how to do this, so I will surely come back with revised code and questions when I can finally get back to it.