What am i doing wrong

**DiashFlash** · 01-19-2004

Here is the source code

Code:

#include <iostream.h>
            #include <stdlib.h>

            void demonstrationfunction()
            {
             cout "hello\n";
            }

             int main()
             {

             system("PAUSE");
             return 0;
             }

When i compile it it says that something is wrong In function`void demonstrationfunction()':
parse error before string constant

**Keybone** · 01-19-2004

cout is used like this:

cout << "text you want out";

It's base things.Might wanna look up a tutorial.

**cyberCLoWn** · 01-19-2004

Code:

#include <iostream>
using std::cout;
#include <stdlib.h>
This isn't needed

            void demonstrationfunction()
            {
cout is not complete. You need the insertion operator.
             cout << "hello\n";
            }

             int main()
             {
You have to call the function for it to be able to do anything. Add in:
             demonstrationfunction();
             system("PAUSE");
             return 0;
             }

Try and see if it works now.

**DiashFlash** · 01-19-2004

Thanks for help cyberclown.I have readed the basic in c++ but now i need some more advanced tutorials

**major_small** · 01-19-2004

functions are still very basic C++... and if your going to use <stdlib.h>, I suggest you use <cstdlib> instead... newer standards... and system("pause"); isn't very portable... I would use something like this:

Code:

...
std::cout<<"Press any key to continue . . .";
std::cin.get();
...

or

Code:

#include <conio.h>
...
std::cout<<"Press any key to continue . . .";
getch();
...

I'm not too sure about the portability of the second one though... I just like it better because it doesn't wait for a \r...

**WaltP** · 01-19-2004

Originally posted by major_small
... and system("pause"); isn't very portable... I would use something like this:

Code:

#include <conio.h> ... std::cout<<"Press any key to continue . . ."; getch(); ...

I'm not too sure about the portability of the second one though... I just like it better because it doesn't wait for a \r...

It isn't. getch() is a great function iff you have it defined in your compiler, but most compilers don't.

**major_small** · 01-19-2004

I've been able to use it in every compiler i've used...

**Prelude** · 01-19-2004

>I've been able to use it in every compiler i've used...
That isn't an excuse. When we speak of portability, we mean every compiler on every platform that supports C++. You should know by now that the "works for me" approach to programming is fraught with peril...mostly the peril of us telling you that you're an idiot.

Anyway, to correct your code:

Code:

std::cout<<"Press any key to continue . . .";
std::cin.get();

C++ input is line oriented, which means the program won't continue until a newline is entered. So the prompt should be changed to

Code:

std::cout<<"Press return to continue . . .";
std::cin.get();

**WaltP** · 01-19-2004

Originally posted by major_small
I've been able to use it in every compiler i've used...

Unless you've tried all 137 compilers, so what? I've used compilers they haven't worked on. And I'll bet Salem, Prelude, Hammer, and many others have too. Ignorance of other options is dangerous. And you've been around these boards long enough to know getch() is NOT standard. It's nice to suggest using the "newer standards" but don't ignore the old standards.

**major_small** · 01-19-2004

>>Unless you've tried all 137 compilers
you've counted? :rolleyes:

prelude: I know... I usually use cin.get and put "press return to continue . . ."

>>It's nice to suggest using the "newer standards" but don't ignore the old standards.
what do the 'old standards' have to offer that the newer standards don't cover when it comes to using cstdlib?

Thread: What am i doing wrong

Thread Tools

Search Thread

Display

What am i doing wrong

Similar Threads

Problem with input choice... Somethings wrong... really wrong....

Debugging-Looking in the wrong places

Confused: What is wrong with void??

God

Whats wrong?