My first attempt at a Template

This doesn't work. It makes sense in my head but it doesn't compile. As usual I've probably done something stupid and am unable to see it. Any help is always appreciated.

Code:

---

#include <iostream>
using namespace std;

// Prototypes


// Templates
template < class T >
T min( T value1, T value2 )
{ 
  T min = value1;

  if( value1 > value2 )
  {
      min = value2;
      return min;
  }
  else
      return min;
}

int main()
{
  int number, number1, choose;
  char charac, charac1;
  double doub, doub1;
 
  cout << "Number = 1\nDouble = 2\nCharacter = 3";
  cin >> choose;
 
  switch (choose)
  {
      case 1:
              cout << "Enter a number: ";
              cin >> number;
              cout << "\nEnter a number: ";
              cin >> number1;
 
              cout << "\n\nSmallest is: " << min( number, number1 );
              break;
      case 2:
              cout << "Enter a double: ";
              cin >> doub;
              cout << "\nEnter a double: ";
              cin >> doub1;
 
              cout << "\n\nSmallest is: " << min( doub, doub1 );
              break;
      case 3:
              cout << "Enter a char: ";
              cin >> charac;
              cout << "\nEnter a char: ";
              cin >> chrac1;
 
              cout << "\n\nSmallest is: " << min( charac, charac1 );
              break;
      }
     
  system( "pause" );
  return 0;
}

---

Did your compiler not tell you the error was?

Code:

---

VC++ 6.0
G:\jDocument\CSCI\231\experiment\cboard.cpp(53) : error C2065: 'chrac1' :
undeclared identifier

.....
case 3:
              cout << "Enter a char: ";
              cin >> charac;
              cout << "\nEnter a char: ";
              cin >> chrac1;  <-- misspelled

...

---

Sorry, how stupid of me. Here is the error.

Quote:

---

In function `int main()':
call of overloaded `min(int&, int&)' is ambiguous
candidates are: T min(T, T) [with T = int]
const _Tp& std::min(const _Tp&, const _Tp&) [with _Tp = int]

call of overloaded `min(double&, double&)' is ambiguous
candidates are: T min(T, T) [with T = double]
const _Tp& std::min(const _Tp&, const _Tp&) [with _Tp = double]

call of overloaded `min(char&, char&)' is ambiguous
candidates are: T min(T, T) [with T = char]
const _Tp& std::min(const _Tp&, const _Tp&) [with _Tp = char]

Execution terminated

---

I've corrected the typo, thanks.

The identifier min() is already used somewhere in the STL. Just rename your function my_min() or something like that, and it ought to compile.

Oh my word! How thick! It works now. Changed it to minimum. Thanks! *goes to work on Towers*

How come it ran fine on my vc++ 6.0???
EDIT: if we don't include the library/header where min() is in, is there still conflict??

> How come it ran fine on my vc++ 6.0???
MSVC 6.0 should not be used to gauge anything involving expected or defined behavior (especially when the STL is involved).

>EDIT: if we don't include the library/header where min() is in, is there still conflict??
Correct. A better solution is to not "pollute the namespace" with lines like 'using namespace std;'

Yah, I use 'using namespace std;' only when working on practise exercises (lazy). When I make a proper program I specify each individual item that the program uses from the header files.