Test script error

[Aalmaron]

i was making a script to test some operations, and i can't seem to run it, because i get an error on line 21. could you guys tell me what i'm doing wrong.

#include <iostream.h>
#include <stdlib.h>
//dex = dexterity str = strength ac = the armor of the goblin dmg = damage
int main()
{
    int dex, str, ac;
    cout << "what is your dex?(1-20): ";  //lets the player choose the dex
    cin >> dex;
    cout << "\nwhat is your str?(1-20): ";  //lets the player choose the str
    cin >> str;
    ac = rand(20);
    if(dex && str<20);  //checks to make sure the player isnt cheating
    {
        if(dex>ac); //checks to see if the player's dex is high enough to hit the goblin
        {
             float HtoH = .5; //HtoH = hand to hand skill
             float dmg = dex * str;
             dmg = dmg * HtoH;
             cout << "you hit the goblin for " << dmg << endl; //tells the player how much he hit for
        }
        else 
        {
             cout<< "you did not hit" endl;  //if the players dex was too low
        }
    else
    {
        cout<< "not above 20!" endl;  //if the player tried to cheat
    }
return 0;
}

i bet it totaly obvious, but i can't seem to find it.

[Shakti]

if(dex>ac);     // Get rid of semicolon

[Salem]

> if(dex && str<20);
Both your if() have a stray ;

[Aalmaron]

hah, wow thanks guys!

[Sang-drax]

Originally posted by Aalmaron

//dex = dexterity str = strength ac = the armor of the goblin 
[...]
if(dex && str<20);  //checks to make sure the player isnt cheating

Don't use short variable names that makes to type comments like the one above. Use obvious names like goblinArmour etc.

And that if-statment should look like this (I imagine):

if (dex<=20 && str<=20)

Also make sure each { has a matching }.

[Aalmaron]

yeah i was thinking about changing my variable names, shorthand sucks.

my old if statement worked, but you're right, it isn't pretty like yours

i've been messing with it alot though, it barely looks like that anymore. if you want, i'll post it tomorrow after i fix the random goblin attack.

[jlou]

Originally posted by Aalmaron
my old if statement worked, but you're right, it isn't pretty like yours

Do you mean if (dex && str < 20) worked? If so, I doubt it worked in all cases. Users can put in whatever positive number they want for the dexterity and the if statement would evaluate to true. If I gave 5000 as my dexterity and 10 as my strength, then the if statement would be if ((5000) && (10<20)). Since 5000 is non-zero, it evaluates to true and true, which is true, but not what you want.

[Aalmaron]

wow, i didnt test it like that, you're right.

i had changed it to before

if(dex && str <= 20)

ok now i changed it to

if(dex <= 20 && str <= 20 && dex >= 0 && str >= 0)

also, i'm having form problems with my damage numbers.

float phealth = 100;
int dex, str, PlayerArmor; 
float dmg;
float HandtoHand = .5;
int weaponbonus = 5; // weapon bonus, only 5 because its his fists

those are my player variables. playerarmor is randomed, but that doesnt matter here.

                   if(dex > GoblinArmor) //checks to see if the player's dex is high enough to hit the goblin
                     {
                     dmg = dex * str;
                     dmg = dmg * HandtoHand;
                     dmg = dmg * AttackRandom;
                     dmg = dmg + weaponbonus;
                     cout << "you hit the goblin for " << dmg << " damage" << endl; //tells the player how much he hit for
                     ghealth = ghealth - dmg;
                     cout << "the goblin has " << ghealth << " Hit points left" << endl;
                     }//closing player hit if
                   else
                     {
                     cout << "you did not hit" << endl;  //if the players dex was too low
                     }//closing player hit else

thats my code for attack. but when i play it, it deals 5 damage every time, which is the weapon bonus. when i take the add weapon bonus line out, then i do normal damage.