else if...

Is it better to use:

Code:

---

if(stuff)
{
    stuff
}
else
{
    if(stuff)
    {
        stuff
    }
    else
    {
          stuff
    }
}

---

or:

Code:

---

if(stuff)
{
    stuff
}
break;
if(stuff)
{
    stuff
}
else
{
    stuff
}

---

I'm not sure if I got that right, but whatever.

the first one since break is used to exit a loop.

Code:

---

while(1)
{
      if(...)
        break;

      ....
}

---

Quote:

---

Originally posted by gcn_zelda
Is it better to use:

Code:

---

if(stuff)
{
    stuff
}
else
{
    if(stuff)
    {
        stuff
    }
    else
    {
          stuff
    }
}

---

or:

Code:

---

if(stuff)
{
    stuff
}
break;
if(stuff)
{
    stuff
}
else
{
    stuff
}

---

I'm not sure if I got that right, but whatever.

---

Your two pieces of code do completely different things. The first one won't even work outside of a loop or switch. Also, in your first one, if you are in a loop, anything after the first if statement will never be executed because no matter what, the break statement will be reached. You most-likely meant to put the break inside your first if statement. Post the rest of your code and then we can say which you should use (or provide another solution).

Yeah. I was just wondering. I haven't written the code yet.
I see what I did wrong.

Code:

---

if(stuff)
{
    stuff
}
else if(stuff)
{
    stuff
}
else
{
    stuff
}

---

This is the same logically as your first one, but in my opinion is more readable.

like everybody else said, the break; won't compile unless it's in a loop... and what's under it won't happen because it breaks out of the loop before it does... for readability, I would set it up like this:

Code:

---

if(true)
    doSomething

if(SomeThingElseIstrue)
    DoSomethingElse
else
    DoSomethingDifferent

---

I prefer a minor change to jlou's idea:

Code:

---

if(stuff)
{
    stuff
}
else
if(stuff)
{
    stuff
}
else
{
    stuff
}

---

major_small's idea simply removes the first else, which is probably not a good idea.

Quote:

---

Originally posted by WaltP

Code:

---

else
if(stuff)

---

---

Eewww, gross! ;)

Code:

---

if(cond1) ...
else if(cond2) expr2
else ...

---

and

Code:

---

if(cond1) ...
if(cond2) expr2
else expr3

---

Are potentially different depending on your conditions, so make sure you know which one you intend to use. The first will only execute expr2 if cond1==false and cond2==true, and expr3 if both cond1 and cond2 are false. The second will execute expr2 if cond2==true regardless of what cond1 is, and similarly, the execution of expr3 is dependent only on the truth value of cond2.

Quote:

---

Originally posted by jlou
Eewww, gross! ;)

---

To each his own, I guess. ;)

Quote:

---

Originally posted by WaltP
major_small's idea simply removes the first else, which is probably not a good idea.

---

actually, jlou's idea puts it in, which is a bad idea... check the original code ;)

what jlou did could make the program skip a check that the programmer wanted done, for example:

Code:

---

if(foo==true)
    do that;
else if(bar==true) //skipped if foo is true
    do nothing;
else
    do this;

---

that doesn't take into account that in this run, both foo and bar are true and the program is supposed to do this and that

Quote:

---

Originally posted by major_small
actually, jlou's idea puts it in, which is a bad idea... check the original code ;)

---

Just did. Original post was:

Code:

---

if(stuff)
{
    stuff
}
else
{
    if(stuff)
    {
        stuff
    }
    else
    {
          stuff
    }
}

---

Quote:

---

Originally posted by major_small
what jlou did could make the program skip a check that the programmer wanted done...

---

No, what jlou did was reformat the code to:

Code:

---

if(stuff)
{
    stuff
}
else if(stuff)
{
    stuff
}
else
{
    stuff
}

---

All he really did was change the indentation.

oh I see... I read the second piece of code, which was meant to do the same thing as the first piece of code... sorry.