Rate My Code: Function Usage & File Streaming

Code:

---

#include <iostream>
#include <fstream>

#include <cstdlib>
#include <cstring>

#define MAX        256

  using std::ofstream;
  using std::ifstream;
  using std::cout;
  using std::cerr;
  using std::cin;
  using std::endl;
  using std::string;



void FilePrint( ofstream& output, string strFile, string strText )
{

    output.open( strFile.c_str() );
   
   
    if( !output.is_open() )
    {
   
        cerr << "Unable To Open: " << strFile.c_str() << endl;
        exit(1);
    }
   
    else
    {
   
        output << strText.c_str() << endl;
    }
   
   
    output.close();
}


void FileGet( ifstream& input, string strFile, char *cBuffer, const int SIZE )
{

    input.open( strFile.c_str() );
   
   
    if( !input.is_open() )
    {
   
        cerr << "Unable To Open: " << strFile.c_str() << endl;
        exit(1);
    }
   
    else
    {
   
        while( !input.eof() )
        {
       
          input.getline( cBuffer, SIZE );
          cout << cBuffer << endl;
        }
       
    }
   
   
    input.close();
}


int main( int argc, char *argv[] )
{

    ofstream fout;
    ifstream fin;
   
    char Buffer[MAX];
   

    FilePrint( fout, "Example.txt", "Hello World!!\nHow Are You Today?!" );
    FileGet( fin, "Example.txt", Buffer, MAX );


    cin.get();
    return EXIT_SUCCESS;

}

---

>using std::string;
You want to include <string> instead of <cstring>. <cstring> holds functions for manipulating C-style strings, <string> declares the std::string class and helper functions.

>void FilePrint( ofstream& output, string strFile, string strText )
Why do you pass a stream reference to a function that opens it upon being called and closes it before returning? This strikes me as a good place to use a local variable and shorten your argument lists.

>exit(1);
The exit function has three standard arguments, 0, EXIT_SUCCESS, and EXIT_FAILURE. Anything else is implementation-defined, so if you want your programs to be portable, use one of the above.

>output << strText.c_str() << endl;
Calling c_str() is not needed, C++ streams are well aware of how to output std::strings.

>output.close();
This technically isn't needed since the destructor will flush the stream and close it for you.

>while( !input.eof() )
This will bite you eventually. Testing for eof is not meant to be used as a loop condition. See the FAQ for further details about why this is so.

>int main( int argc, char *argv[] )
The arguments to main are not used, so you should not include them in the definition.

>char Buffer[MAX];
Why use a C-string as the buffer when a C++ string would be better in just about every way?

Your overuse of empty lines makes the code more difficult to read, but at least the indention is fairly consistent.

>char Buffer[MAX];
>>Why use a C-string as the buffer when a C++ string would be >>better in just about every way?
Can we do this, though??

Code:

---

string str;
stream.getline(str, MAX);

---

How about some prototypes?

>Can we do this, though??
No, the string class has its own getline function:

Code:

---

string str;
getline ( stream, str );

---

Code:

---

#include <iostream>    // For C++ Input/Output Stream
#include <fstream>      // For File Input/Output Stream

#include <cstdlib>      // Standard C Library
#include <string>      // For std::string

  using std::cout;
  using std::cerr;
  using std::cin;
  using std::endl;
  using std::ofstream;
  using std::ifstream;
  using std::string;
 
 
void FileOutput( string, string );
void FileInput( string );



int main( )
{

    FileOutput( "Example.txt", "Hello World!!\nHow Are You Today?!" );
    FileInput( "Example.txt" );


    cin.get();
    return EXIT_SUCCESS;
}


void FileOutput( string strFile, string strText )
{

    ofstream output( strFile.c_str() );


    if( !output.is_open() )
    {

        cerr << "Unable To Open " << strFile << endl;
        exit( EXIT_FAILURE );
    }

    else
    {

        output << strText << endl;
    }

}


void FileInput( string strFile )
{

    ifstream input( strFile.c_str() );
    string strBuffer;


    if( !input.is_open() )
    {

        cerr << "Unable To Open: " << strFile << endl;
        exit( EXIT_FAILURE );
    }

    else
    {

        while( !input.eof() )
        {

          getline( input, strBuffer );
          cout << strBuffer << endl;
        }

    }

}

---

Better?

getting there. reread preludes post especially the bit pointing you to the FAQ.

Code:

---

#include <iostream>    // For C++ Input/Output Stream
#include <fstream>      // For File Input/Output Stream

#include <cstdlib>      // Standard C Library
#include <string>      // For std::string

  using std::cout;
  using std::cerr;
  using std::cin;
  using std::endl;
  using std::ofstream;
  using std::ifstream;
  using std::string;


void FileOutput( string, string );
void FileInput( string );



int main( void )
{

    FileOutput( "Example.txt", "Hello World!!\nHow Are You Today?!\nFine I hope...." );
    FileInput( "Example.txt" );


    cin.get();
    return EXIT_SUCCESS;
}


void FileOutput( string strFile, string strText )
{

    ofstream output( strFile.c_str() );


    if( !output.is_open() )
    {

        cerr << "Unable To Open " << strFile << endl;
        exit( EXIT_FAILURE );
    }

    else
    {

        output << strText << endl;
    }

}


void FileInput( string strFile )
{

    ifstream input( strFile.c_str() );
    string strBuffer;
    int line= 0;


    if( !input.is_open() )
    {

        cerr << "Unable To Open: " << strFile << endl;
        exit( EXIT_FAILURE );
    }

    else
    {
   
        ++line;

        while( getline( input, strBuffer ) != NULL )
        {

          cout << "Line " << line << ": " << strBuffer << '\n';
          line++;
        }

    }

}

---

This is perfect.........I hope...

Quote:

---

Originally posted by KingZoolerius66
This is perfect.........I hope...

---

It's a program -- they are never perfect :p

http://gamedev.net/community/forums/...opic_id=198193

ha, sup Leiarchy9