Rate My Application: File Exception Handling

Hello. I recently learned about the try, throw and catch methods so I decided to combine that recently retrieved knowledge with my knowldge of file streaming(ifstream, ofstream, fstream). I made two different versions of the application and they both work perfectly on Windows XP.

The first one is just a regular console. While the second one is a console along with a pop-up window dialogue(WinAPI: MessageBox( HWND, char*, char*, unsigned short int ) ).

Note: My prototype for the MessageBox function maybe off but who cares. It's been years since I programmed in Win32/WinAPI.

The second one. It's exactly identical, its just that the application reads the data from the .txt file and then displays it's content in a dialogue box.

1) Very few people will take the time to download your code, review it, and post back here. Paste code in your post and you may get better results.

2) Code reviews are two-way. I haven't gotten feedback from the review I gave you of your previous program, why should I waste my time sending another review to the bit bucket? It may have helped you, you may not have read it...I just don't know.

So your first order of business is to be more considerate to the people you are asking to review your code. A good review takes time and effort and we don't have to do it, remember that.

Both files
First thing: lack of comments.

Code:

     using namespace std;
     using std::ifstream;

This is a wee bit redundant.

Code:

     FileException( std::string error, std::string file ):
                  strErrMsg(error), strFilename(file) {}
                  
     std::string strErrMsg;
     std::string strFilename;

You are 'using namespace std', and you are still referencing the string class with the std:: prefix? Tsk, tsk, tsk.

Code:

int main( )

int main( void )
This way you are explicitly stating that there are no arguments that can be passed to main.

Code:

     return EXIT_SUCCESS;

Not necessary. A return value on success in C++ is not required.



From the 1st file:

Code:

cout << strName.c_str() << '\n';

The ofstream class is capable of handling STL strings, so you don't need the c_str( ) call.



From the 2nd file:

Code:

        std::string strFile= "Name.txt";
        ifstream fin( strFile.c_str() );

Redundant. Just use ifstream fin( "Name.txt" );

Originally posted by XSquared

Code:

int main( )

int main( void )
This way you are explicitly stating that there are no arguments that can be passed to main.

You're thinking of C. In C++ int main() is explicit. The (void) is just as redundant as the other redundant items you mention elsewhere in your post.

>>You're thinking of C. In C++ int main() is explicit.
Thanks for pointing that out. I forgot that it was C-only.