Address will always return true? (class vectors + member vars)

For some reason, i cannot get the value of a member from my vector. My compiler tells me this :

"32 C:\My Documents\LIAUNG PRESENTATION\Doopey.cpp
[Warning] the address of `int will always be true"

I tried different combos of asterisks, point tos, and good old spaces, but to no avail. i.e :

Code:

 return AllQuestions [ Asked - 1 ].Answer ;
 return *AllQuestions [ Asked - 1 ]->Answer ;
 return *AllQuestions [ Asked - 1 ].Answer ;

The offending functions are GetEndAnswer and GetEndUserAnswer, which just get members from the last element of a vector of Questions. I have no idea why they returns a 1/true/nonzero - they 'should' return
10 or 20. Is there something i have missed that makes it try to return a pointer or somesuch?

Code:

#include <iostream>
#include <vector>
using namespace std;
int Asked = 0;

class Question {
public :
	int Answer;
	int UserAnswer;
	Question();
};

Question::Question ()
{
	Answer = 10;
	UserAnswer = 20;
	Asked ++;
}

vector <Question> AllQuestions;

int GetEndAnswer()
{ return AllQuestions [ Asked - 1 ].Answer; }

int GetEndUserAnswer()
{ return AllQuestions [ Asked - 1 ].UserAnswer; }

int main()
{
	AllQuestions.push_back ( Question );
	cout << GetEndAnswer << GetEndUserAnswer;
	system ("PAUSE");
	return 0;
}

Code:

AllQuestions.push_back ( Question );

What exactly are you trying to do with this line?

trying to push a new Question object onto the vector. I 'think' it's legal syntax, or do you have to have a name?

Try AllQuestions.push_back ( Question());.

please dont tell me it doesn't work becaues there ARE no questions on the vector...... would that make the things return 1? I did compile it, and it outputs 11. (or truetrue). glort?

Still doesnt work, even with the parentheses.

Then try a Question variable.

I compiled using Question() and got this:

Code:

	Question Temp;
	AllQuestions.push_back ( Temp );
	cout << GetEndAnswer << GetEndUserAnswer;

still does exact same thing. It is the push, or the actual functions?

If you are going to be using a vector, you should store the index where you use it.

Its the functions, try this code:

Code:

#include <iostream>
#include <vector>
using namespace std;
int Asked = 0;

class Question {
public :
	int Answer;
	int UserAnswer;
	Question();
};

Question::Question ()
{
	Answer = 10;
	UserAnswer = 20;
	Asked ++;
}

vector <Question> AllQuestions;

int main()
{
	AllQuestions.push_back ( Question());
	cout << AllQuestions [ Asked - 1 ].Answer << " " << AllQuestions [ Asked - 1 ].UserAnswer << endl;
	system ("PAUSE");
	return 0;
}

looks like that works, yeah. Thanks for the quick responses.
I winder why it doesnt work as a function? Might have to ponder that one.

Originally posted by littleweseth
looks like that works, yeah. Thanks for the quick responses.
I winder why it doesnt work as a function? Might have to ponder that one.

It didn't work as a function because you forgot the parentheses when calling the function, so it just output the function's address:

Code:

cout << GetEndAnswer() << GetEndUserAnswer();

repeat above: dont prgram when you start seeing sheep flying across your FoV, crying *zzzZZZZ! zzzZZZ!*

obivous things like that are the reason why you get others to debug - you tend to see your own code as what you think it is, not what it is.