Derived member variables in initializer lists

Code:

---

class A
{
public:
      int nData;
};

class B : public A
{
public:
      B():nData(0) {} //<----Causes error
      ~B() {}
};

---

The marked line causes this error:

Quote:

---

error C2614: 'B' : illegal member initialization: 'nData' is not a base or member

---

Is there any way to initialize derived variables in a list like the way I have tried?

You can't initialize members of a base class in the constructor of the derived class.

Members are initialized in the constructor: nData is initialized in A() (default ctor)

So you cannot initialize nData in B
You need to call an appropriate constructor of A in B to initialize nData.

BTW:
public or protected member variables are harmful - do not use them unless you really really need to.

I don't see any problem in protected member variables.

Protected member variables are as bad as public. Your derived classes should access the base object through a protected interface just as non-derived classes access the base object through the public interface.

It should be possible to completely reinvent the implementation of a base class, while keeping the same interface, and not have to do ANYTHING besides replace the base class source and recompile.

You essentially want as little coupling between classes as you can; this minimizes the impact of an implementation change.

The ONLY reason to use them is if a code profiler tells you that accessor functions are a serious problem from an efficiency standpoint. They *always* negatively affect coupling, so only if there is a necessary performance gain should you make the tradeoff.

Got your point. But if I was developing a base class and a few derived classes at the same time (to be treated as one unit), I'd probably still have some protected member variables.

You could... I still would avoid that; it's typically unnecessary if you write your classes well. And in the cases you need it, I typically just inline an accessor method -- speed and low coupling.

Quote:

---

Your derived classes should access the base object through a protected interface just as non-derived classes access the base object through the public interface.

---

Could you show an example of this?

I would do something like that:

Code:

---

class A {
public:
    A(int n = 0) : n(n) {}
    ~A() {}

    int GetN() { return n; }
    void SetN(int n) { this->n = n; }

private:
    int n;
};

class B : public A {
public:
    B() : A(0) {}
    ~B() {}
};

// A protected interface would have been
class A {
public:
    A(int n = 0) : n(n), m(0) {}
    ~A() {}

    // Accessors, n is publicly accessible
    int GetN() { return n; }
    void SetN(int n) { this->n = n; }

protected:
    // You can construct an object with an initialized m member in your derived class
    A(int n = 0, int m = 0) : n(n), m(m) {}

    // Accessors, m is accessible by the derived classes
    int GetM() { return m; }
    void SetM(int m) { this->m = m; }

private:
    int n;
    int m;
};

class B : public A {
public:
    B(int m) : A(0, m) {}
    ~B() {}
};

---

How could this be applied to an actual problem?

One example is MFC. You can derive window classes from CWnd/CDialog/etc., and you access the base through its interface. This means you, as the programmer, need never be concerned with implementation.

In general, it is always better to make the variable private; it minimizes coupling, and coupling is a bad thing.

Ok, I'll keep that in mind. So, in summary, I should call the base constructor to initialize my base class variable?

Code:

---

class A
{
public:
    int nValue;

    A(int nValue_=0):nValue(nValue_) {}
    ~A() {}
};

class B : public A
{
public:
    B(int nValue_=1):A(nValue_) {}
    ~B() {}
};

---

Actually MFC is a very bad example as nearly everything there is public...

Quote:

---

Originally posted by CornedBee
Actually MFC is a very bad example as nearly everything there is public...

---

In CWnd, the only public variable is m_hWnd -- which SHOULD be private (it even has an accessor function), but isn't.

I count 3 public and about 8 protected members in CWnd, not including the stuff inherited from CCmdTarget (another 3 public at least).