Binary to Dec Source Code

Code:

---

#include <iostream>
#include <fstream>

#include <conio.h>
#include <stdlib.h>

using namespace std;

class binAndDec
{
        public:

                int loadFromFile(char File[10]);
                void binToDec();

                char textString[6];
                char Copy[6];
                int n;
};

int binAndDec::loadFromFile(char File[10])
{
        char text;

        ifstream tFile(File);
        tFile.get(textString);
        tFile.close();



        if(textString==0)
        {
                cout << "NULL File!" << endl;
                return 1;
        }
        return 0;
}

void binAndDec::binToDec()
{
        for(int tmp=0;tmp<6;tmp++)
        {
                Copy[tmp]=textString[tmp];
        }
        n=0;

    for (int x=0; Copy[x] != '\0' && (Copy[x] == '1' || Copy[x] == '0'); x++)
    {
        n <<= 1; 
        if (Copy[x]== '1')
                {
            n += 1;
                }
    }
}


int main()
{
        binAndDec mains;
        if(mains.loadFromFile("text.txt")==1)
        {
                return 1;
        }
        else
        {
                mains.binToDec();
                cout << (char)mains.n << endl;
        }
        getch();
        return 0;
}

---

My question is what's wrong when I use the get function? I'm going to set it up to load more than one string of binary. Any ideas?

Quote:

---

My question is what's wrong when I use the get function?

---

Why don't you tell us? What are the errors?

sry, I was a little tired last night.

Code:

---

D:\Programs\Projects\hex\main.cpp(27) : error C2664: 'class std::basic_istream<char,struct std::char_traits<char> > &__thiscall std::basic_istream<char,struct std::char_traits<char> >::get(char &)' : cannot convert parameter 1 from 'char [6]' to 'ch
ar &'

---

that's pointing at the use of get.

You cannot use get() to read a string of characters, only single characters.
Use getline() or the >> operator to read a string

well, getline seeems to be undefined... what library do I need for that... I thought it was stdio.h but it still doesn't work then.

What do I use to include getline?
Is there anything else I can use if that isn't in my library?

getline() is included in iostream.h. So i can't understand the problem you are having.

getline( ) is actually in iostream. Not iostream.h.

I get an unideclared identifyer for getline. Anyone wanna show me how it's used?

sounds like you are passing a variable name that hasn't been declared previously in your code. And xsquared: i know the declaration of getline is within the iostream.h file, and not the actual object code its self.

no, it's saying that getline is undeclared.

[copy]
D:\Programs\Projects\hex\main.cpp(26) : error C2065: 'getline' : undeclared identifier
[/copy]

Isn't that what this means?

Actually, what I meant is that you should never use <iostream.h>, just <iostream>.

can you post the code so i can have a quick look at it?

Code:

---

#include <iostream>
#include <fstream>

#include <conio.h>
#include <stdlib.h>

using namespace std;

class binAndDec
{
        public:

                int loadFromFile(char File[10]);
                void binToDec();

                char textString[6];
                char Copy[6];
                int n;
};

int binAndDec::loadFromFile(char File[10])
{
        char text;

        ifstream tFile(File);
        tFile >> text;
        getline(text);
                    //I've also tried just doing a direct getline(tFile)
        tFile.close();



        if(textString==0)
        {
                cout << "NULL File!" << endl;
                return 1;
        }
        return 0;
}

void binAndDec::binToDec()
{
        for(int tmp=0;tmp<6;tmp++)
        {
                Copy[tmp]=textString[tmp];
        }
        n=0;

    for (int x=0; Copy[x] != '\0' && (Copy[x] == '1' || Copy[x] == '0'); x++)
    {
        n <<= 1; 
        if (Copy[x]== '1')
                {
            n += 1;
                }
    }
}


int main()
{
        binAndDec mains;
        if(mains.loadFromFile("text.txt")==1)
        {
                return 1;
        }
        else
        {
                mains.binToDec();
                cout << (char)mains.n << endl;
        }
        getch();
        return 0;
}

---

you have to pass in the number of bytes you want getline to read. Additionally, you also need to call the method from the ifstream object, so it knows to read from the file stream associated with the file and not the stdin filestream.

so try,

infile.getline(data, 80);

Code:

---

getline( infile, data, 80 );

---

[edit]Dang, beaten

Here is a very quick example, going bed now as i've got to be up at 5 am. :-(

Code:

---

#include <fstream.h>

#define BUFF_LEN 80

int main(void)
{
  char Data[BUFF_LEN];
  ifstream InFile;

  InFile.open("Test.txt");

  InFile.getline(Data, BUFF_LEN);
  InFile.close();

  cout << Data;

  getchar();

  return 0;
}

---

Don't use old-style headers. Use <fstream> and using namespace std;.