Copying one string from s2[] to s1[]

[steve_demaio]

I have to copy one string from

const char s2[]

to

char s1[]

All this is to be done without using the uber elite

<cstring>

library. So no

strcpy()

. This is to be done within a function, so assume everything out of the function is properly done. My main question was, without using strcpy, or the cstring library, is there a more efficient way of doing this then I have listed here.

void strcat(char s1[], const char s2[]) {
    int i = 0;

    while ( (s1[i] = s2[i]) != '\O')
          i++;

    s1[i] = '\O';  // This line is not altogether necessary, but just helps anyway. 
}

Thanks for any replies!

[glUser3f]

> s1[i] = '\O'; // This line is not altogether necessary, but just helps anyway.

How the heck is it supposed to be helpful if not necessary?? And it's '\0' not '\O'

[steve_demaio]

Yeah, dunno why I hit an O. I'm still half asleep.

And it was helpful just because if for some reason the while loop didn't copy over the '\0' then it would insert a new '\0' at the end of the string just to help.

Array size is irrelevant here because of the fixed length values the function would work with.

[glUser3f]

you won't get out of the while loop unless a '\0' is copied to s1, so I don't see any need to add that line, this will make your function more efficient.

[steve_demaio]

Ahh, ok. Thanks!

[swoopy]

>void strcat(char s1[], const char s2[])

Just curious, why did you name it strcat if you're doing a string copy?