Please help with String class, returning strings

I'm desperate here, please be gracious. I just don't know what to do with this CStringIterator class function that returns the current word in a string.

Here's main:

Code:

void main()
{
	int integer;
	char* bob = "Bob";
	char* tim = "Tim";

	CString tester ("Tyson Lee Kirksey");
	CString tester2;
	
	CStringIterator Iter (tester);

	cout << Iter.CurrentCharacter()<< endl;

	Iter.MoveForward();
	Iter.MoveForward();
	Iter.MoveForward();
	Iter.MoveForward();
	Iter.MoveForward();

	cout << Iter.CurrentCharacter()<< endl;

	//Iter.MoveToFront();

	tester2.Set (Iter.CurrentWord());
	CStringIterator Iter2 (tester2);

	cout << Iter2.CurrentCharacter();

Here's CString StringIterator::CurrentWord()

Code:

CString CStringIterator::CurrentWord ()
{
	//CString return_me;
	//return_me = new CString;

	char* NewString = new char[40];
	//return_me = CString(NewString);

	int first;
	int last;
	int length = m_String.Length() - 1;
	int count1 = 0;
	int count2 = 0;
	int total;

	if (AtWhiteSpace())
	{
		//return_me.Set(" ");
		//return_me.pString[1] = '\0';
		NewString[0] = ' ';
		NewString[1] = '\0';
		return NewString;
	}
	else
	{
		do
		{
			MoveForward();
			count1++;
		}
		while (!AtWhiteSpace() && (m_Index + count1) != length);
		if (AtWhiteSpace())
			last = m_Index - 1;
		else					// The last point is now known
			last = m_Index;
		
		m_Index = m_Index - count1;

		do
		{
			MovePrevious();
			count2++;
		}
		while (!AtWhiteSpace() && m_Index != 0);

		if (AtWhiteSpace())
			first = m_Index + 1;
		else
			first = 0;

		m_Index = m_Index + count2;

		//Create the new String

		total = last - first;
		for (int count3 = 0; count3 <= total; count3++)
		{
//			return_me.pString[count3] = m_String.pString[first];
			first++;
		}
	    
		//add null terminator
//		return_me.pString[total + 1] = '\0';
	//	return return_me;
	}
}

Here's CString::Set

Code:

void CString::Set(CString NewString)
{
	//char* NewString = new char[newStringLength];
	char* pString = new char[NewString.Length()+1];
	strcpy(pString,NewString.pString);

	//add the NULL value on end
	pString[strlen(pString)] = '\0';
}

It compiles fine but crashes. All I need to do is return a new CString that contains the current word. Can anybody help please?

Is this CString class your own or the one from MFC? Next with out all the code it would not be very easy to see exactly what your doing. What is the crash that occurs? To return the CString you could simply call the Contructor that takes a char* as an argument like so:

Code:

return CString(NewString);

That will create a unnamed temporary object.

Its my own class, here's how it looks:

Code:

class CString
{
	
	friend class CStringIterator;

   public:
	   CString(); //works
	   CString(CString &string); //works
	   CString(char*); //works
	   ~CString(); //works
	   //void Set(char* NewString);
	   void Set(CString NewString);
	   bool IsEmpty(); //works
	   int Length(); //works
	   //void Append(char* NewString); //works but don't need
	   void Append(CString &NewString); //works
	   //bool Compare(char* NewString); 
	   bool Compare(CString NewString);//works
	   void Empty(); //works   
	   void Display(); //works
	   void Cool_Function(); //works

   private:
	   char* pString;

};

Stepping thru it w/ the debugger, when I'm finished setting tester2 to Iter.CurrentWord, tester2's value says "Bad PTR". How come?

I will need to see all of the code in order to fully understand what you're doing. Please zip it and send it to me. Then I can help you out.

Ah, forget about it. I got it working. Thanks for offering though.