Copy Problems.

The following code compiles clean, and executes without error, however when the objects are printed out, they appear to be empty. The datafile is just a big list of numbers, nothing fancy. Im looking for somebody to tell me what im doing wrong, how to fix it, and if there is a faster way than copy to fill my vector.

Code:

#include <algorithm>
#include <vector>
#include <iostream>
#include <fstream>

using namespace std;

class Bob
{
	public:
		int a;
		int b;
		int c;
		int d;
		int e;
		int f;
		Bob(void);
		Bob(int,int,int,int,int,int);
		~Bob(void);
		friend std::ostream operator << (std::ostream, Bob);
		friend std::istream operator >> (std::istream, Bob);
};

Bob::Bob()
{
	a=0;
	b=0;
	c=0;
	d=0;
	e=0;
	f=0;
}

Bob::~Bob()
{
}

Bob::Bob(int q, int w, int s, int r, int t, int y)
{
	a = q;
	b = w;
	c = s;
	d = r;
	e = t;
	f = y;
}

std::ostream operator << (std::ostream mystream, const Bob theobject)
{
	mystream << theobject.a << " " << theobject.b << " " << theobject.c << " "
			 << theobject.d << " " << theobject.e << " " << theobject.f;
	mystream << std::endl;
	return mystream;
}

std::istream operator >> (std::istream mystream, Bob theobject)
{
	mystream >> theobject.a;
	mystream >> theobject.b;
	mystream >> theobject.c;
	mystream >> theobject.d;
	mystream >> theobject.e;
	mystream >> theobject.f;
	return mystream;
}


void main()
{

	string filename = "test.txt";
	ifstream datafile;
	datafile.open(filename.c_str());

	vector<Bob> Bobs;
	
	copy( ( istream_iterator<Bob> (datafile) ),istream_iterator<Bob>(),back_inserter(Bobs));

	cout << Bobs.size() << " Records Read!" << endl << endl;
	cout << "The first bob contains: " << Bobs[0] << endl;
	cout << "The next  bob contains: " << Bobs[1] << endl;
	cout << "The next  bob contains: " << Bobs[2] << endl;
}

Code:

friend std:: ostream operator

you are using using namespace std so why do you do the std:: thing? Is it something more advanced?

By empty, do you mean not printing out anything, or printing out garbage for those variables?

As a side note, why not make the 6 ints a vector?

>> Is it something more advanced?

Nope... Relics from a previous rendition of the program would be my guess.

>> Is it something more advanced?

<<Nope... Relics from a previous rendition of the program would be my guess. [/B][/QUOTE]



What do you mean?

empty as in the default constructor executed and they are 0's. as for the vector of ints, this entire program is nothing more than an example generated to demonstrate my problem. as for the std:: i got lazy halfway through. im just so used to typing it and not using namespace std that i still do it half the time.

Would that create problems using both or no?

no, it causes no problems. its fair to use "using namespace std", or simply stick a std:: in front of everything, or a combonation of both. i have never had it cause problems.

>> Would that create problems using both or no?

Nope.

As for the problem, try passing the streams by reference (and then returning the reference), since you are modifying the object (stream) in the overloaded operators.

Shouldn't your variables be in private or protected instead of public?

JaWiB - nope. note that this is nothing more than an example to demonstrate a problem im having. much simpler to take 5 minutes and crank out lazy code to show the problem than post 2000 lines and ask people to try and understand it.

Zach L. - i just tested the code (by spitting out values during the copy) and it seems the stream isnt the problem, but the Bob object is the problem during the copy. inside the copy it contains the correct values, however outside the copy it contains only zeros. im not sure how to fix this because if i try and pass the object by reference it complains saying it will only pass the object Bob and not *Bob. ideas?

Wait, are you passing by pointer? Pass by reference:

ostream & operator<<(ostream & mystream, const Bob &theObject)

A Bob& is not (to the language) the same as a Bob*.

That should work, but unless you have another copy constructor that doesn't copy construct correctly, the other way should have worked (it would just be inefficient).

Try this:

Remove these two lines:

Code:

friend std::ostream& operator << (std::ostream&, Bob&);
friend std::istream& operator >> (std::istream&, Bob&);

OR make them like so:

Code:

friend std::ostream& operator << (std::ostream&, const Bob&);
friend std::istream& operator >> (std::istream&, Bob&);

Change these:

Code:

std::ostream& operator << (std::ostream& mystream, const Bob &theobject)

std::istream& operator >> (std::istream& mystream, Bob &theobject)

(note the & usage)

[edit]
Added replacement for friend functions