Returning failure result for operator << istream

This is a discussion on Returning failure result for operator << istream within the C++ Programming forums, part of the General Programming Boards category; I'm trying to read and write a class from/to disk, but altough it works, I want to implement better error ...

  1. #1
    Registered User
    Join Date
    Jun 2003
    Posts
    245

    Question Returning failure result for operator << istream

    I'm trying to read and write a class from/to disk, but altough it works, I want to implement better error checking, but not sure how to do it. I would have thought that using stream.read would cause an exception if an attempt to read past the end of the file occured, but it doesn't seem to.

    At the moment, my loader code is something like this:

    Code:
    		ifstream FooLoader (filename, ios::binary);
    
    		if (FooLoader.is_open())
    		{
    			FooClass p;
    
    			clear(); // empty the array
    			FooLoader >> p;
    			while (FooLoader.eof() == FALSE)
    			{
    				append (p);
                                                                    FooLoader >> p;
    			}
    			FooLoader.close();
    			return 1;
    		}
    		else return 0;
    The above is part of FooTemplate, which is a subclassed vector template and contains additional features like customised array system with full disk I/O tailored to my app.

    Now, my >> operator code is as follows:

    Code:
    istream & operator >> (istream &stream, FooClass &obj)
    {
       stream.read ((char *)&obj.Time, sizeof(obj.Time));
       stream.read ((char *)&obj.ID, sizeof(obj.ID));
       
       stream.read (&obj.BinDataSize, sizeof(obj.BinDataSize));
       if (obj.BinDataSize)
       {
          if (obj.BinData) free [] obj.BinData;
          obj.BinData = new char[obj.BinDataSize];
          stream.read (obj.BinData, obj.BinDataSize);
       }
       return stream;
    }

    Now, although this works, the things I don't like about this are:

    Reading an extra element which could allocate upto 255 bytes for no reason. Sure, it'll get cleaned up by the destructor when "p" goes out of scope, but it's ugly and I don't like it.

    Lack of error detection. How can I tell if a "stream.read" command failed? It doesn't return the number of bytes actually read, despite the compiler documentation stating it does.

    Since I have to return a stream (why?), how do I return an error status from my reading function? The only way I can think of is "throw", but I don't want to have to put a "try... catch" around every place where it will call the routine.

    EDIT: I fixed the ZeroMemory issue by adding a copy-constructor. Updated code is now above.
    Last edited by _Elixia_; 07-06-2003 at 05:02 AM.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. istream
    By Beowolf in forum C++ Programming
    Replies: 3
    Last Post: 10-30-2007, 06:11 PM
  2. Stupid compiler errors
    By ChrisEacrett in forum C++ Programming
    Replies: 9
    Last Post: 11-30-2003, 05:44 PM
  3. Error returning istream in class implementation.
    By joshdick in forum C++ Programming
    Replies: 8
    Last Post: 12-29-2002, 03:02 PM
  4. <list>
    By Unregistered in forum C++ Programming
    Replies: 9
    Last Post: 02-24-2002, 04:07 PM
  5. Returning result of an external function
    By Unregistered in forum C Programming
    Replies: 1
    Last Post: 11-21-2001, 06:39 PM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21