Tic-Tac-Toe errors

I get lots of errors for this:

Code:

#include<iostream>
#include<windows.h>
#include<conio.h>
#include<cstdlib>
using namespace std;

char a1=' ';
char a2=' ';
char a3=' ';
char b1=' ';
char b2=' ';
char b3=' ';
char c1=' ';
char c2=' ';
char c3=' ';


bool Check();
void DrawBoard();
void DrawHelpBoard();

int main(){
	cout<<"Tic-Tac-Toe!\n";
	int move;
	char X_or_O;
	char O_or_X;
	int xo=rand()%2;
	if(xo=0){
		X_or_O='X';
		O_or_X='O';
		cout<<"You are X";
	if(xo=1){
		X_or_O='O';
		O_or_X='X';
		cout<<"You are O";
		}
	Sleep(2000);
	while(Check())
		clrscr();
		DrawBoard();
		DrawHelpBoard();
		cin>>move;
		if(move=1 && a1!=X_or_O){a1=X_or_O;}
			else if(move==2 && a2!=X_or_O){a2=X_or_O;}
			else if(move==3 && a3!=X_or_O){a3=X_or_O;}
			else if(move==4 && b1!=X_or_O){b1=X_or_O;}
			else if(move==5 && b2!=X_or_O){b2=X_or_O;}
			else if(move==6 && b3!=X_or_O){b3=X_or_O;}
			else if(move==7 && c1!=X_or_O){c1=X_or_O;}
			else if(move==8 && c2!=X_or_O){c2=X_or_O;}
			else if(move==9 && c3!=X_or_O){a1=X_or_O;}
			else{
				MessageBox(NULL, "Not a valid space", "ERROR", MB_OK);
};
}


void DrawBoard(){
	cout<<a1<<"|"<<a2<<"|"<<*a3<<"|\n------"<<b1<<"|"<<b2<<"|"<<b3<<"|\n------"<<c1<<"|"<<c2<<"|"<<c3<<"|\n\n";
}
void DrawHelpBoard(){
	cout<<"1|2|3|\n------4|5|6|\n------7|8|9|";
}
bool Check(){
	if (a1='X' && a2='X' && a3='X'){ return FALSE;}
	else if (b1=='X' && b2='X' && b3='X'){ return FALSE;}
	else if (c1=='X' && c2='X' && c3='X'){ return FALSE;}
	else if (a1=='X' && b1='X' && c1='X'){ return FALSE;}
	else if (a2=='X' && b2='X' && c2='X'){ return FALSE;}
	else if (a3=='X' && b3='X' && c3='X'){ return FALSE;}
	else if (a1=='X' && b2='X' && c3='X'){ return FALSE;}
	else if (a3=='X' && b2='X' && c1='X'){ return FALSE;}

	else if (a1=='O' && a2='O' && a3='O'){ return FALSE;}
	else if (b1=='O' && b2='O' && b3='O'){ return FALSE;}
	else if (c1=='O' && c2='O' && c3='O'){ return FALSE;}
	else if (a1=='O' && b1='O' && c1='O'){ return FALSE;}
	else if (a2=='O' && b2='O' && c2='O'){ return FALSE;}
	else if (a3=='O' && b3='O' && c3='O'){ return FALSE;}
	else if (a1=='O' && b2='O' && c3='O'){ return FALSE;}
	else if (a3=='O' && b2='O' && c1='O'){ return FALSE;}
	else{
		return TRUE;
};
}

Errors:

Code:

Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
tictactoe.cpp:
Warning W8060 tictactoe.cpp 28: Possibly incorrect assignment in function main(

Warning W8060 tictactoe.cpp 32: Possibly incorrect assignment in function main(

Warning W8060 tictactoe.cpp 43: Possibly incorrect assignment in function main(

Error E2141 tictactoe.cpp 58: Declaration syntax error in function main()
Error E2139 tictactoe.cpp 85: Declaration missing ; in function main()
Error E2134 tictactoe.cpp 85: Compound statement missing } in function main()
Warning W8004 tictactoe.cpp 85: 'xo' is assigned a value that is never used in
unction main()
Warning W8004 tictactoe.cpp 85: 'O_or_X' is assigned a value that is never used
in function main()
*** 3 errors in Compile ***

Edited code and posted errors

Indent your code, please.

Remember: anything in double quotes "" is a const char*. You're defining your types as char.

Remember: a single equals sign means assignment. int a = 1 will always be true because 1 is true. You want to say if (a == 1) ...

You also have extra '}' or '{' signs.

You're working way too hard to create this program. You don't need so many else if statements. Look for shortcuts.

I changed some code in my post above and added the errors. Sorry for delay. Technical difficulties.

Originally posted by fuh
I changed some code in my post above and added the errors. Sorry for delay. Technical difficulties.

You only changed the first comparisons from '=' to '=='. There are more than one of those in a line you need to change.

instead of using

Code:

char a1=' ';
char a2=' ';
char a3=' ';
char b1=' ';
char b2=' ';
char b3=' ';
char c1=' ';
char c2=' ';
char c3=' ';

you should use an array of chars...just because it's simpler

Code:

char board[9]={' ',' ',' ',' ',' ',' ',' ',' ',' '};

Also, 'false' is a C++ keyword (a bool), not 'FALSE'. 'FALSE' and 'TRUE' probably have one of the following definitions somewhere:

#define FALSE 0
#define TRUE 1

or

const int FALSE = 0;
const int TRUE = 1;

or

enum BOOL = { FALSE = 0, TRUE };

1 and 0 will always evaluate to the boolean true or false, resplectively, but the all caps versions are not actually keywords.

Originally posted by Zach L.
enum BOOL = { FALSE = 0, TRUE };

Two minor points:

1) The first = sign is incorrect. Remove it.
2) The second = sign, and the following 0 are actually not needed. Yet I myself include them for clarity. The first enum value, if not assigned to any specific value, will always be 0, with the next one being 1 and the next being 2 and so on...

Thus:

enum BOOL { FALSE, TRUE };

Would suffice.

Quzah.

I got rid of most errors and warnings (1 or 2 was I hadn't put the computer in), but still get these:

Code:

C:\Borland\BCC55\zack>bcc32 -I..\include -L..\lib tictactoe
Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
tictactoe.cpp:
Error E2379 tictactoe.cpp 47: Statement missing ; in function main() Huh?
Error E2134 tictactoe.cpp 74: Compound statement missing } in function main() For what? 
Warning W8004 tictactoe.cpp 74: 'O_or_X' is assigned a value that is never used No AI yet error, I'll fix that later.
in function main()
*** 2 errors in Compile ***

For this:

Code:

#include<iostream>
#include<windows.h>
#include<conio.h>
#include<cstdlib>
using namespace std;

char board[9]={' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '};

bool Check();
void DrawBoard();
void DrawHelpBoard();

int main(){
	cout<<"Tic-Tac-Toe!\n";
	int move;
	char X_or_O;
	char O_or_X;
	int xo=rand()%2;
	if(xo==0){
		X_or_O='X';
		O_or_X='O';
		cout<<"You are X";
	if(xo==1){
		X_or_O='O';
		O_or_X='X';
		cout<<"You are O";
		}
	Sleep(2000);
	while(Check())
		clrscr();
		DrawBoard();
		DrawHelpBoard();
		cin>>move;
		if(move==1 && board[0]!=X_or_O){board[0]=X_or_O;}
			else if(move==2 && board[1]!=X_or_O){board[1]=X_or_O;}
			else if(move==3 && board[2]!=X_or_O){board[2]=X_or_O;}
			else if(move==4 && board[3]!=X_or_O){board[3]=X_or_O;}
			else if(move==5 && board[4]!=X_or_O){board[4]=X_or_O;}
			else if(move==6 && board[5]!=X_or_O){board[5]=X_or_O;}
			else if(move==7 && board[6]!=X_or_O){board[6]=X_or_O;}
			else if(move==8 && board[7]!=X_or_O){board[7]=X_or_O;}
			else if(move==9 && board[8]!=X_or_O){board[8]=X_or_O;}
			else{
				MessageBox(NULL, "Not a valid space", "ERROR", MB_OK);
};
}
DrawBoard(){
	cout<<board[1]<<"|"<<board[2]<<"|"<<*board[3]<<"|\n------"<<board[4]<<"|"<<board[4]<<"|"<<board[4]<<"|\n------"<<board[4]<<"|"<<board[8]<<"|"<<board[8]<<"|\n\n";
}
DrawHelpBoard(){
	cout<<"1|2|3|\n------4|5|6|\n------7|8|9|";
}
Check(){
	if (board[0]='X' && board[1]='X' && board[2]='X'){ return false;}
	else if (board[3]=='X' && board[4]=='X' && board[5]=='X'){ return false;}
	else if (board[6]=='X' && board[7]=='X' && board[8]=='X'){ return false;}
	else if (board[0]=='X' && board[4]=='X' && board[8]=='X'){ return false;}
	else if (board[0]=='X' && board[3]=='X' && board[6]=='X'){ return false;}
	else if (board[1]=='X' && board[4]=='X' && board[7]=='X'){ return false;}
	else if (board[2]=='X' && board[5]=='X' && board[8]=='X'){ return false;}
	else if (board[2]=='X' && board[4]=='X' && board[6]=='X'){ return false;}

	else if (board[1]=='O' && board[2]=='O' && board[3]='O'){ return false;}
	else if (board[4]=='O' && board[4]=='O' && board[4]='O'){ return false;}
	else if (board[4]=='O' && board[8]=='O' && board[8]='O'){ return false;}
	else if (board[1]=='O' && board[4]=='O' && board[4]='O'){ return false;}
	else if (board[2]=='O' && board[4]=='O' && board[8]='O'){ return false;}
	else if (board[3]=='O' && board[4]=='O' && board[8]='O'){ return false;}
	else if (board[1]=='O' && board[4]=='O' && board[8]='O'){ return false;}
	else if (board[3]=='O' && board[4]=='O' && board[4]='O'){ return false;}
	else{
		return true;
};
}

Thanks, guys!

Code:

if(xo==0){
		X_or_O='X';
		O_or_X='O';
		cout<<"You are X";

You are missing your closing } here.
That is, unless you actually meant to have all of the rest of the entire code as a sub-block of this if statement...

So you can do this

Code:

if(x==0)
     //stuff

but not this?

Code:

while(x==0)
     //stuff

You can do either of those, but only the line following the if/else/while/for/etc., will be executed. The brackets are there to enclose exactly what you want to be executed given a certain condition.

>>You can do either of those, but only the line following the if/else/while/for/etc., will be executed

Oh. I thought he wanted to do that.

Originally posted by gcn_zelda
So you can do this
...snip...
but not this?
...snip...

You're missing the problem. The problem is you don't have braces around a block. After an if/for/do-while/while statement, you only get one code statement or block to execute. Illustrated:

Code:

if ( foo == bar )
    this_line_on_true( );
this_line_always( );

If you wanted both to happen if foo == bar, then you need to wrap them in braces:

Code:

if ( foo == bar )
{
    this_line_on_true( );
    this_line_always( );
}

Now then, the second function call will only happen if foo==bar, because they are both enclosed in the same braces pair. (ie: the came scope block)

Otherwise, without braces, only the next following statement executes.

[edit] Curses, foiled again. [/edit]

Quzah.

I fixed the braces error, but can't figure out the semicolon error.

Originally posted by Salem

Then I suggest you repost your latest code then

Here it is:

Code:

#include<iostream>
#include<windows.h>
#include<conio.h>
#include<cstdlib>
using namespace std;

char board[9]={' ', ' ', ' ', ' ', ' ', ' ', ' ', ' ', ' '};

bool Check();
void DrawBoard();
void DrawHelpBoard();

int main(){
	cout<<"Tic-Tac-Toe!\n";
	int move;
	char X_or_O;
	char O_or_X;
	int xo=rand()%2;
	if(xo==0){
		X_or_O='X';
		O_or_X='O';
		cout<<"You are X";}
	if(xo==1){
		X_or_O='O';
		O_or_X='X';
		cout<<"You are O";
		}
	Sleep(2000);
	while(Check()){
		clrscr();
		DrawBoard();
		DrawHelpBoard();
		cin>>move;
		if(move==1 && board[0]!=X_or_O){board[0]=X_or_O;}
			else if(move==2 && board[1]!=X_or_O){board[1]=X_or_O;}
			else if(move==3 && board[2]!=X_or_O){board[2]=X_or_O;}
			else if(move==4 && board[3]!=X_or_O){board[3]=X_or_O;}
			else if(move==5 && board[4]!=X_or_O){board[4]=X_or_O;}
			else if(move==6 && board[5]!=X_or_O){board[5]=X_or_O;}
			else if(move==7 && board[6]!=X_or_O){board[6]=X_or_O;}
			else if(move==8 && board[7]!=X_or_O){board[7]=X_or_O;}
			else if(move==9 && board[8]!=X_or_O){board[8]=X_or_O;}
			else{
				MessageBox(NULL, "Not a valid space", "ERROR", MB_OK);
};
};
DrawBoard()
{
	cout<<board[0]<<"|"<<board[1]<<"|"<<board[2]<<"|\n------"<<board[3]<<"|"<<board[4]<<"|"<<board[5]<<"|\n------"<<board[6]<<"|"<<board[7]<<"|"<<board[8]<<"|\n\n";
}
DrawHelpBoard(){
	cout<<"1|2|3|\n------4|5|6|\n------7|8|9|";
}
Check(){
	if (board[0]='X' && board[1]='X' && board[2]='X'){ return false;}
	else if (board[3]=='X' && board[4]=='X' && board[5]=='X'){ return false;}
	else if (board[6]=='X' && board[7]=='X' && board[8]=='X'){ return false;}
	else if (board[0]=='X' && board[4]=='X' && board[8]=='X'){ return false;}
	else if (board[0]=='X' && board[3]=='X' && board[6]=='X'){ return false;}
	else if (board[1]=='X' && board[4]=='X' && board[7]=='X'){ return false;}
	else if (board[2]=='X' && board[5]=='X' && board[8]=='X'){ return false;}
	else if (board[2]=='X' && board[4]=='X' && board[6]=='X'){ return false;}

	else if (board[1]=='O' && board[2]=='O' && board[3]='O'){ return false;}
	else if (board[4]=='O' && board[4]=='O' && board[4]='O'){ return false;}
	else if (board[4]=='O' && board[8]=='O' && board[8]='O'){ return false;}
	else if (board[1]=='O' && board[4]=='O' && board[4]='O'){ return false;}
	else if (board[2]=='O' && board[4]=='O' && board[8]='O'){ return false;}
	else if (board[3]=='O' && board[4]=='O' && board[8]='O'){ return false;}
	else if (board[1]=='O' && board[4]=='O' && board[8]='O'){ return false;}
	else if (board[3]=='O' && board[4]=='O' && board[4]='O'){ return false;}
	else{
		return true;
};
}
}

I still havn't added the opponent yet.