Thread: traversing a linked list with a node and list class

I am having trouble finding a way to traverse the linked list. I am trying to write the copy constructor, but keep having a memory crash. The nodes seem to be being created but the data is garbage.

Here is the constructor:

Code:

linkList::linkList(const linkList &originalList)
{
	linkList tmpList;
	if (_debugging)
		cout << "tmpList created." << endl;

	for (node *i = originalList._firstElement; i->next != NULL; i = i->next)
	{
		tmpList.add(i);
		
		if (i->next == NULL)
		{
			break;
		}
	}

}

Here is the add function that is also part of the linkList class:

Code:

void	linkList::add(node *newnode)
{

	node * newNode = newnode;
	if (isEmpty())
	{
		_firstElement = newNode = _lastElement;
		_numElements ++;

		if (_debugging)
			cout << "New node added to the list." << endl;
	}
	else
	{
		_lastElement->next = newNode;
		_lastElement = newNode;
		_numElements ++;

		if (_debugging)
			cout << "New node added to the list." << endl;
	}

}

Any ideas why this is happening?

I have made the changes you suggested, but I am getting the same results.

Maybe I am implementing this in my test file incorrectly. I am trying to create a list using another list. Like this:

Code:

linkList list2(list1);  // Where list1 is an already created list with 3 node objects

Is this what the copy constructor is for? Or am I confusing the copy constructor with the assignment operator?