help with proggy!

[gcn_zelda]

OK! I shall tell the problem!!! 1. Character constant too long!!!
2. no match for 'string & == integer'
3.It pops up and dissapears in Dev C++!!!

#include <iostream.h>
#include <string>

int main()
{
cout << "The world is about to be destroyed. You are in a futuristic spy base." << endl;
cout << "You will soon go on a mission to save the world. In the corner of the room," << endl;
cout << "you see a plant. The door is to the north and the basement is down." << endl;
std::string firstroom;
cin >> firstroom;
if(firstroom == 'x plant')
{
cout << "As you examine the plant, you spot a glint of silver in the soil." << endl;
std::string plant;
cin >> plant;
if(plant == 'x glint')
{
plant:
cout << "You pick up the glint. It is a keycard to the NETWORK." << endl;
std::string glint;
cin >> glint;
}
if(plant == 'get glint')
{
goto plant;
}
return 0;
}

[Stoned_Coder]

you need "" around strings and ' ' around single chars. so

char c = 'c'; // is fine
string s = ' wassup '; // is an error. need "" not ''

[quzah]

goto d;

*screams* My eyes! My eyes! They're bleeding!

Quzah.

[gcn_zelda]

also, Dev C++ says parse error at end of input

[quzah]

Originally posted by gcn_zelda
also, Dev C++ says parse error at end of input

Every place in your above code where you use single quotes ', replace it with ", as you've already been instructed.

Quzah.

[XSquared]

And if I'm counting correctly, you have more opening braces than closing ones. Looks like you forgot a closing one right after cin>>plant;

[RoD]

Originally posted by quzah
*screams* My eyes! My eyes! They're bleeding!

Quzah.

I'm so incredibly sick of the constant cracks on the use of goto! Granted it shouldnt be a newbie practice, but goto has its place and its use, and it gets old that people are constantly bashing a perfectly good function. If your going to make a comment like that at least explain it too him, please.

[quzah]

Originally posted by RoD
I'm so incredibly sick of the constant cracks on the use of goto! Granted it shouldnt be a newbie practice, but goto has its place and its use, and it gets old that people are constantly bashing a perfectly good function. If your going to make a comment like that at least explain it too him, please.

At the risk of turning this into an entirely pointless debate on the use of goto, I'll add the following:

I have yet to ever find a place where it required the use for goto, other than to intentionally obfuscate code. Yes, I've heard it's "handy" for jumping from deep nested loops, but again, I have never ever found use for one.

Were you to take a few seconds to look at their code, you'd find this is also true here:

int main()
{
    [--snip text output--]

    std::string firstroom;
    cin >> firstroom;
    if(firstroom == 'x plant')
    {
        [--snip text output--]
        std::string plant;
        cin >> plant;
        if(plant == 'x glint')
        {
            plant:
            [--snip text output--]
            std::string glint;
            cin >> glint;
        }
        if(plant == 'get glint')
        {
            goto plant;
        }
        return 0;
}

First off, their entire approach to the game is definately wrong. However, allowing for newbie-ism, we can easily fix this to not use goto:

int main()
{
    [--snip text output--]

    std::string firstroom;
    cin >> firstroom;
    if(firstroom == 'x plant')
    {
        [--snip text output--]
        std::string plant;
        cin >> plant;
        if(plant == 'x glint' || plant == 'get glint' )
        {
            [--snip text output--]
            std::string glint;
            cin >> glint;
        }
        return 0;
}

I've left their other errors in tact, just for the hell of it. I don't feel the need to bother telling people who won't even read sticky notes on how to use code tags, reasons to or not to use goto.

Seriously, the person I should be telling is either their instructor, or the author of their book. Goto should be one of the last things taught. Why? Because that's about how useful it is. IE: It's worthless for nearly everything you will ever write in your lifetime. It deserves barely a passing glance, and as such, should be treated and taught in said manner.

Quzah.