Part of my C++ code

I just started c++ the other day and I can't get the program to load, I didn't bother to do the whole code because if this part doesn't work, then what's to stop me to make the same mistake through the whole program?

Code:

---

#include <iostream.h>
#include <stdlib.h>
float Health();
float Attack();
float Defense();
float Spider();
int main()
{
cout<<"Welcome to the Battle Arena!\n"<<endl;
}
float Health()
{
float x;
x = 1 + rand() % 5;
if (x >= 20)
return 15;
else
return x;
cout<<"Your starting Health is: \n"<<Health;
}
float Defense()
{
float y;
y = 5 + rand();
if (y > 20)
return y;
else
return 20;
{
cout<<"Your starting Defense is: \n"<<Defense;
}
cout<<"Your first Enemy is the poison Spider!\n"<<endl;
float Spider();
{
float a;
a = 5 + rand();
if (a > 10)
return 7;
else
return 5;
}
{
cout<<"Spider's Health is: \n"<<Spider;
cout<<"Attack?\n"<<endl;
}
}

---

it works, your not calling anything in main + you should ALWAYS use return 0; in main!

Theres alot wrong with this code. For one you should code a bit neater. Use spaces, follow the flow of what you are trying to do, and keep track of your curly braces ( {} ). For two your converting int to floats, why not just use both floats or both int's? For three i would reccomend you either learn/use classes or parameters so you aren't returning so many things, just imo of course.

Start by giving main a return 0;

Than make some function calls in the main. Only things in main are executed, having 400 functions means nothing without any invoking of those functions.

threw together a quick example of your code with classes. I still reccomend you revise the logic and how you do things in it, but see how much neater and (for the most part) clearer this is? If there is anything you don't understand were more than glad to help/improve on it. The most important thing in C++ is to never give up and never stop learning.

Code:

---

#include <iostream.h>
#include <stdlib.h>

class Actions
{
public:
        float health();
        float attack();
        float defense();
        float spider();
private:
        float x,
                  y,
                  a,
                  Health,
                  Defense,
                  Spider;
};

int main()
{
        Actions        Object;

        cout << "Welcome to the Battle Arena!" << endl;
       
        Object.health();
        Object.attack();
        Object.defense();
        Object.spider();
       
        return 0;
}

float Actions::health()
{
       
        x = 1 + rand() % 5;

        if (x >= 20)
        {
                return 15;
        }
        else
        {
                return x;
        }

cout << "Your starting Health is: " << Health << endl;

}

float Actions::defense()
{
       
        y = 5 + rand();

        if (y > 20)
        {
                return y;
        }
        else
        {
                return 20;
        }

cout << "Your starting Defense is: " << Defense << endl;
cout << "Your first Enemy is the poison Spider!" << endl;

}

float Actions::spider()
{

        a = 5 + rand();

        if (a > 10)
        {
                return 7;
        }
        else
        {
                return 5;
        }

cout << "Spider's Health is: " << Spider << endl;
cout << "Attack? " << endl;
}

---

Why are you returning 1 in main(), RoD?

typo, i fixed it.

Indent your code, its the ONLY way. Its absolutly 100% more proffesional.

I'm more than willing to help you with this, btw, feel free to PM/Email me if u run into a wall, i'm logging off soon.

Thanks, I was thinking that I would just rush into making a decent game on my first day and it wasn't working, then I got mad, and I started looking for message boards to ask questions.

Would anyone happen to know how to use graphics in a program, so that I could like make a Galaga look alike or something of the sort?

theres a few ways, do you mean console or like actual game graphics. Check out the game forum, theres alot of links and information there.

How would I change what letters are. Like if I were to make up a new alphabet, how would I make a=(some other letter). If anyone if familiar with the game Final Fantasy 10, I am trying to make my own new alphabet like Al Bhed, just changing where the letter are in the alphabet.

Quote:

---

Originally posted by Maverick
How would I change what letters are. Like if I were to make up a new alphabet, how would I make a=(some other letter). If anyone if familiar with the game Final Fantasy 10, I am trying to make my own new alphabet like Al Bhed, just changing where the letter are in the alphabet.

---

How about a lookup table, something like that used in ASCII to EBCDIC conversions.