Thread: Can someone help me see why this simple program is NOT working please?

why don't you just do:

Code:

cin >> icode;

you can always input a string as a whole.
and then you do comparing like this:

Code:

strcmp(code, icode); //you should include <cstring>

and that should make it work fine.

It might be because code is actually 'a','b','c','d','e','\0' (null terminated) and when you check for icode, its 'a','b','c','d','e' (without the null terminator) and therefore it doesn't think it's the same. Try including the code in single commas so it doesn't have null termination.

Thanks alot
But I did it like that because in the future I'm going to do something like this

Code:

if (icode[i] == code[0])
{
    correct++; 
}

And like that to tell the user how many correct letters he got.

Thanks everyone, I finally made ir work, here it is if anyone cares

Code:

#include <iostream>
#include <cstring>
using namespace std;

int main()
{
	char code[6] = "abcde";
	char icode[6];
	char letter;
	char opcion;

	bool playagain = false;

	int i = 0;

	do
	{
		icode[5] = '\0';
		cout << "Try to guess a code I have thought of:\n";

		for (i = 0; i < 5; i++)
		{
			cin >> letter;

			icode[i] = letter;
		}
	} while (strcmp(code, icode));

	return 0;
}

Thanks again everyone

Ok, Ok I have made it much better, only problem is, I cant think of a way to make a random code that has only the letters "abcde" and that does not repeat them, Any ideas?
BTW this what I have now:

Code:

#include <iostream>
#include <cstring>
#include <ctime>
using namespace std;

int main()
{

	char code[6] = "abcde";
	char icode[6];
	char letter;
	char opcion;

	bool playagain = false;

	int i = 0;
	int correct = 0;

	do
	{
		do
		{
			icode[5] = '\0';
			cout << "Try to guess a code I have thought of:\n";

			for (i = 0; i < 5; i++)
			{
				cin >> letter;

				icode[i] = letter;

				if (icode[i] == code[i])
				{
					correct++;
				}
			}
			cout << "You had " << correct << " correct letters!\n";

			if (!strcmp(code, icode))
			{
				cout << "You guessed the code!\n";
			}
			correct = 0;

		} while (strcmp(code, icode));

		cout << "Do you want to play again? (y/n)\n";
		cin >> opcion;
		playagain = (opcion == 'y' ? true : false);

	} while (playagain);

	return 0;
}

Yes I know its a horrible code, but I make functions and all that to make it look better latter...