Thread: My calc program?

I kept getting errors and warnings on this code, but before I post the errors, I am sure you can pick them out by yourselves with this being such a low level code.

Code:

#include <iostream>

using namespace std;

int add()
{
	unsigned long int a;
	unsigned long int b;
	cout << "\nFirst number: ";
	cin.get >> a;
	cout << "\nSecond number: ";
	cin.get >> b;
	cout << "\nAnswer: ";
	cout << a + b;
	cin.get;
	menu();
	return 0;
}

int subtract()
{
	unsigned long int a;
	unsigned long int b;
	cout << "\nFirst number: ";
	cin.get >> a;
	cout << "\nSecond number: ";
	cin.get >> b;
	cout << "\nAnswer: ";
	cout << a - b;
	cin.get;
	menu();
	return 0;
}

int multiply()
{
	unsigned long int a;
	unsigned long int b;
	cout << "\nFirst number: ";
	cin.get >> a;
	cout << "\nSecond number: ";
	cin.get >> b;
	cout << "\nAnswer: ";
	cout << a * b;
	cin.get;
	menu();
	return 0;
}

int devide()
{
	unsigned long int a;
	unsigned long int b;
	cout << "\nFirst number: ";
	cin.get >> a;
	cout << "\nSecond number: ";
	cin.get >> b;
	cout << "\nAnswer: ";
	cout << a / b;
	cin.get;
	menu();
	return 0;
}
		
int menu()
{
	int choice;
	cout << "1. Add\n";
	cout << "2. Subtract\n";
	cout << "3. Multipply\n";
	cout << "4. Devide\n";
	cout << "\n";
	cout << "Choice: ";
	cin.get >> choice;
	if (choice='1') {
		add();
	}
	else if (choice='2') {
		subtract();
	}
	else if (choice='3') {
		multiply();
	}
	else if (choice='4') {
		devide();
	}
	else {
		cout << "Invalid option.";
		menu();
	}
	return 0;
}

int main()
{
	menu();
	return 0;
}

Originally posted by vVv
Your usage of cin.get( ) is wrong. cin.get( ) is a /function/ and it returns the character read. For example

>cin.get >> a;

becomes a = cin.get( ), or simply cin >> a;. Also note that cin overloads the types you supply, so you should make your variables ``char'' instead of ``unsigned int'' if you want to input ascii chars.

>if (choice='1') {

This shouldn't give you an error, but make it ==.

>but before I post the errors, I am sure you can pick them out by
>yourselves with this being such a low level code.

Ignorance. Annoying. Post your errors if you still get any.

Yea I just noticed the if statement was messed up and fixed that, I am going to go and compile to see what I get.

I did what you said, I am not getting any warnings now, but I am getting two errors-

C:\Windows\Desktop\Programming\calc\clac.cpp(16) : error C2065: 'menu' : undeclared identifier
C:\Windows\Desktop\Programming\calc\clac.cpp(66) : error C2373: 'menu' : redefinition; different type modifiers

Thanks, it is finally working

I accually remade it. I was bored and then I thought about remaking it. So here is the new code.

Code:

#include <iostream>
	
using namespace std;
	
int main()
{
	char option;
	float a, b;
	cout << "1. Add" << endl;
	cout << "2. Subtract" << endl;
	cout << "3. Multiply" << endl;
	cout << "4. Devide" << endl << endl; // the extra "<< endl" so it will leave a space between the menu and the "Choice" line 
	cout << "Choice: ";
	cin >> option;
	
	if (option=='1')
	{
		cout << "\nWhat is the first number?: ";
		cin >> a;
		cout << "\nWhat is the second number?: ";
		cin >> b;
		cout << "\nAnswer: ";
		cout << a+b;
	}
	else if (option=='2')
	{
		cout << "\nWhat is the first number?: ";
		cin >> a;
		cout << "\nWhat is the second number?: ";
		cin >> b;
		cout << "\nAnswer: ";
		cout <<	a-b;
	}
	else if (option=='3')
	{
		cout << "\nWhat is the first number?: ";
		cin >> a;
		cout << "\nWhat is the second number?: ";
		cin >> b;
		cout << "\nAnswer: ";
		cout << a*b;
	}
	else if (option=='4')
	{
		cout << "\nWhat is the first number?: ";
		cin >> a;
		cout << "\nWhat is the second number?: ";
		cin >> b;
		cout << "\nAnswer: ";
		cout << a/b;
	}
	else
	{
		cout << "\nThat is an invalid option.";
	}
	return 0;
}

Originally posted by LordVirusXXP
Phew, it's good to know that I'm not the worst programmer on the CBoard

And probably not the best!!!

Come on LordVirusXXP, that was rude and inpolite (like my post).

I don't know how far you are planning on going with this calculator idea, but if you want to make it object oriented you could make a calculator class, and use operator+, operator-, operator/, and operator*.

Code:

...
int a, b, answer;
cout << "enter two numbers to add" << endl;
cin >> a >> b;
answer = mycalc.operator+(a,b);

something along those lines

Originally posted by LordVirusXXP
Phew, it's good to know that I'm not the worst programmer on the CBoard

Well yes I am not very good, yet. But you got to take in the fact I just started a few days before Christmas.