Loading chars from files problem

I'm having trouble loading some chars from a file... I made a code to previously save things into a file, and that works fine. I can't get the loading to work though ( like a load game function ). Here is the code :

Code:

type("What was your filename ?");
cin >> filename;

infile.open(filename, ios::nocreate);
infile >> firname;
infile >> lasname;
infile >> sex;
infile >> location;
infile >> weapon;
infile >> bplace;
infile >> bday;
infile >> bmonth;
infile >> byear;
infile >> age;

type("Your name :\n");
type(firname);
type("\n\nyour character's last name ?\n");
cout << lasname;
type("\n\ncharacter male or female ?\n");
cout << sex;
type("\n\nWhere is your character in the game ?\n");
cout << location;
type("\n\nWhat is your character's primary weapon ?\n");
cout << weapon;
type("\n\nWhat is your character's birthplace ?\n");
cout << bplace;
type("\n\nWhat is your character's birthday ? [Day only]\n");
cout << bday;
type("\n\nWhat is your character's birth month ?\n");
cout << bmonth;
type("\n\nWhat is your character's birth year ?\n");
cout << byear;
type("\n\nTherefore what is your character's age ?\n");
cout << age;
Sleep(500);
cin >> xit;

return 0;
}

This is only part of the code. All chars and ints have been declared. TYPE is a function for a typewriter effect, so treat it as cout.

Can anyone tell me why, when I launch this program, I get :

"Your name is :"


"Your age is :" etc..
instead of

"Your name is :"
"NAME"

"Your age is :"
"AGE".

Thanks for your help.

First, check if the opening of the file failed (infile.fail()).

Second, are you reading the data in the same order as you saved it?

Third, how did you declare the strings?

Four, what's the point of these name-shortenings?

firname;
lasname;

1. What do you mean by File Failed check ? Can you give me an example ?

2. Yes, reading data in the same order as I saved it, but when I go

cout >> "your name is" >> firname

or something of the type I get an empty line.

3. I declared :

char firname[50];

4. I was told never to put just one letter difference between characters cuz I could do typos etc...

Originally posted by Korhedron
1. What do you mean by File Failed check ? Can you give me an example ?

Whenever you open a file for reading or writing, always check if it succeeded. This can be done using the fail() method:

Code:

bool ReadData()
{
   ifstream ReadFile;
   ReadFile.open("MyFile.txt", ios::in);

   if(ReadFile.fail())
   {
      cout << "Unable to open file!" << endl;
      return false;
   }

   ...

   ReadFile.close();
   return true;
}

Remember to close it too.

What's the BOOL ReadData thing ? And what does return true / false do ?

Originally posted by Korhedron
What's the BOOL ReadData thing ? And what does return true / false do ?

Eh? It's a function. bool is the return value (a boolean value is true or false). return means that you exit the function with the specified return value.