What is wrong with this code?

********************Start of The code******************

Code:

#include<iostream>
#include<string>
#include<fstream>
using namespace std;

class Person
{
	string name;
public:
	Person() {name = "Roger";}
	Person(string theName);
	string getName() { return name; }
	void setName(string theName) { name = theName;}
	Person& operator=(const Person& rtSide);
	friend istream &operator>>(istream& inStream, Person& personObject);
	friend ostream &operator<<(ostream& outStream, const Person& personObject);
};

Person& Person::operator=(const Person &rtSide)
{
	name = rtSide.name;
	return *this;
}

istream &operator>>(istream& inStream, Person& personObject)
{
	cout << "PLEASE ENTER NAME: ";
	inStream >> personObject.name;
	return inStream;
}

ostream &operator<<(ostream& outStream, const Person& personObject)
{
	outStream << personObject.name << '\n';
	return outStream;
}

int main()
{
	Person rt("Romano"), rt1("Roger");
	cout << rt;
	return 0;
}

*********************End of Code********************
Can anyone help to figure it our what is wrong with my coding? this are the errors generated by the compiler thanks


--------------------Configuration: assigment3 - Win32 Debug--------------------
Compiling...
as3q3.cpp
C:\Files\assigment3\as3q3.cpp(28) : error C2248: 'name' : cannot access private member declared in class 'Person'
C:\Files\assigment3\as3q3.cpp(8) : see declaration of 'name'
C:\Files\assigment3\as3q3.cpp(34) : error C2248: 'name' : cannot access private member declared in class 'Person'
C:\Files\assigment3\as3q3.cpp(8) : see declaration of 'name'
C:\Files\assigment3\as3q3.cpp(41) : error C2593: 'operator <<' is ambiguous
Error executing cl.exe.

as3q3.obj - 3 error(s), 0 warning(s)



&#91;code]&#91;/code]tagged by Salem

Call setName instead of accessing the string object name directly.

Kuphryn

Put your class in its own namespace with the operators that act on objects of your class in the same namespace. See what happens. You also need to implement your constructor and it would be a good idea to make it explicit to stop automatic implicit conversions of a string to a person.

You forgot to define your Overloaded Constructor!

Code:

Person::Person(string theName){
	this->name = "Roger";
}

here like this....

Code:

#include<iostream>
#include<string>
using namespace std;
namespace{

class Person
{
string name;
public:
Person() {name = "Roger";}
explicit Person(string theName):name(theName){}
string getName() { return name; }
void setName(string theName) { name = theName;}
Person& operator=(const Person& rtSide);
friend istream &operator>>(istream& inStream,Person& personObject);
friend ostream &operator<<(ostream& outStream, const Person& personObject);
};

Person& Person::operator=(const Person &rtSide)
{
name = rtSide.name;
return *this;
}

istream &operator>>(istream& inStream,Person& personObject)
{
cout << "PLEASE ENTER NAME: ";
inStream >> personObject.name;
return inStream;
}

ostream &operator<<(ostream& outStream, const Person& personObject)
{
outStream << personObject.name << '\n';
return outStream;
}

}

int main()
{
Person rt("Romano"), rt1("Roger");
cout << rt;
return 0;
}

The line 28 error is in an overloaded operator for istream or something, right? But since name is a private member of person, nothing outside of the person class can access it, thus generating the error - an istream (or is it even an istream? It sort of looks like a global function to me) is trying to access a private member of person, which it can't. The same goes for the line 34 error.

but the function is declared as a friend and so can access all of persons private data without any problem. The problem was due to some sort of clash within the global namespace. Solution. Put the class in its own namespace with its operators. Now no ambiguity. If you dont like an anonymous namespace then give it a name.

NO, the problem was simple - I just added a definition for the Overloaded Person() constructor and everything worked without change.

He just forgot to define his overloaded fxn, that's what caused the errors.

Code:

#include <iostream>
#include <string>
#include <fstream>
using namespace std;

class Person
{
private:
	string name;
public:
	Person() {this->name = "Roger";}
	Person(string theName);
	string getName() { return this->name; }
	void setName(string theName) { this->name = theName;}
	Person& operator=(const Person& rtSide);
	friend istream &operator>>(istream& inStream, Person& personObject);
	friend ostream &operator<<(ostream& outStream, const Person& personObject);
};

Person::Person(string theName){ //ADDED
	this->name = "Roger";
}

Person& Person::operator=(const Person &rtSide)
{
	this->name = rtSide.name;
	return *this;
}

istream &operator>>(istream& inStream, Person& personObject)
{
	cout << "PLEASE ENTER NAME: ";
	inStream >> personObject.name;
	return inStream;
}

ostream &operator<<(ostream& outStream, const Person& personObject)
{
	outStream << personObject.name << '\n';
	return outStream;
}

int main()
{
	Person rt("Romano"), rt1("Roger");
	cout << rt;
	return 0;
}

Okay, I'll just butt out

Nah, "butt back in". You've got good stuff! Right, or not, an idea is an idea. (Heck, I didn't have any! )

P.S. I learn a lot more from being wrong than I ever do from being right.

-Skipper