.eof will not work in iostream

My program works the only problem I am having is that when it reads the end of file it adds the last score to the total again. here is my program what have I done wrong with.eof?

#include <iostream>
#include <fstream> // File Stream Library

using namespace std;

int main()

{
char team;
int numb, k=0, n=0;
ifstream gamefile;// ifstream variable name declaration
// open file
gamefile.open("/home1/c/a/acsi201/data/game");

//if the file fails to open it will return this statement
if(gamefile.fail())
{
cout << "Input file opening failed.\n";
exit(1);
}

/*while loop keeps reading file till the end of file with if else
statements to compile the scores the winning team would be displayed
first.*/

while(!gamefile.eof()) // while loop
{
gamefile >> team >> numb; //reading the info provided by the file

/* begining of if statement the character K stand for the Knicks
and if team equals K than it will return knicks points scored
otherwise it will return the Nets score.*/

if(team == 'K')
k = k + numb;
else
n = n + numb;
if(k > n)

/* Another if statement for winning team to go first.If the Knicks
score is greater than the Nets than the Knicks score will be
read first otherwise the Nets score will be read first.*/

cout << "Knicks " << k << " Nets " << n << endl;

else
cout << "Nets " << n << " Knicks " << k << endl;
}
// end of whileloop

gamefile.close();// closing of file previousely opened
cout << "Good Game! \n";

/* end of program since a output file was not required, to see output
after compilation run file hw5 < result than at prompt type more
result*/
}

any ideas?

So the loop goes one iteration farther than you want it to???

This is a common problem, it happens because you are using gamefile.eof() incorrectly. The streamstate is set to eof only after you've attempted and failed a read, so the final iteration is really one further than you want. Instead, try either this:

Code:

---

while ( gamefile.good() ) {
  // read data
.
.

---

or

Code:

---

while ( gamefile >> team >> numb ) {
.
.

---

-Prelude

Yes

I guess I will just turn it in. It looked fine until I noticed the output added an the last score again and I have spent 5 hours playing with it to get it to come out right

>I guess I will just turn it in.
I've answered your question and given you two solutions to the problem, did you miss my post?

-Prelude

no I did not miss them, I could not view the info from the file after compiling it with either solution. maybe it works but I cant' see the results like I could before nothing appears but thank you for trying.

>I could not view the info from the file after compiling it with either solution
Then you didn't implement either correctly. Perhaps if you posted your code and a piece of the file that you're reading I can help you fix the problem better. My test works quite nicely:

Code:

---

#include <iostream>
#include <fstream>

using namespace std;

int main()
{
  char team;
  int numb, k=0, n=0;
  ifstream gamefile;
 
  gamefile.open("test.txt");
 
  if(gamefile.fail())
  {
    cout << "Input file opening failed.\n";
    exit(1);
  }
 
  while(gamefile.good())
  {
    gamefile>> team >> numb;
   
    if(team == 'K')
      k = k + numb;
    else
      n = n + numb;

    if(k > n)
      cout << "Knicks " << k << " Nets " << n << endl;
    else
      cout << "Nets " << n << " Knicks " << k << endl;
  }
 
  gamefile.close();
 
  cout << "Good Game! \n";
 
  return 0;
}

---

-Prelude