Constructors for Composed Objects

Hi there

This is my first cpp program, so please be patient with me...


I am trying to practice applying constructors on a composed class, and have learned that in case of a composed class, the outer class ctor is responsible for initialaizing the inner class, and this can be achieved by using an initialization list.

So here's my code:


class Point
{

private:
int x;
int y;
};



class Rectangle
{
public:
Rectangle(int px, int py, int width, int height);
height);
private:

Point x;
Point y;
int m_width;
int m_height;
};


and heres my ctor :

Rectangle::Rectangle(int px,int py,int width,int height)
:x(px),y(py),m_width(width),m_height(height)
{}



Still, I get a compiler error C2664: '__thiscall Point::Point(const class Point &)' : cannot convert parameter 1 from 'int' to 'const class Point &'
Reason: cannot convert from 'int' to 'const class Point'
No constructor could take the source type, or constructor overload resolution was ambiguous

I understand the meaning of this error, but isnt this what init. list are for?


Please help!


Thanks

Gozlan

In your Point class definition you have to also add constructor(s) and a destructor. Right now there isn't any.

I did now.

I added
Point(int px,int py);
~Point();

to my Point class.

Still , I get the same error

Post the code where you are attempting to instantiate the objects.

What I've specified below is the only code I've written.


Still, it should compile without object instantiating.

Since there is no inheritance involved there seems to be some sort of conflict regarding access, so you might have to use an accessor method or else make Point a friend of Rectangle. I'm not sure, I'm just learning C++ myself.

point.h file:

Code:

---

#ifndef _point_h
#define _point_h

class Point
{
 public:

  Point() { _x = 0; _y = 0; }
  ~Point () { }
  void Set(int x, int y) { _x = x; _y = y; }

    private:
  int _x;
  int _y;
};

class Rectangle
{
 public:
  Rectangle (int, int, int, int);
  ~Rectangle() { }
 private:
  Point x;
  int _width;
  int _height;
};


Rectangle::Rectangle (int p1, int p2, int width, int height)
  {
    _width = width;
    _height = height;
    x.Set(p1,p2);
  }

#endif

---

point.cpp file

Code:

---

#include"point.h"
#include<iostream>

int main()
{
  Rectangle rec(2,4,30,50);
 
  return 0;
}

---

T

Thanks Troll King


I would like to get to the bottom of this initialization list , which is supposed to enable an efficient initialization of composed objects.


Unless of course I got the whole idea wrong , which I am counting on the members of this forum to let me know.

I wouldn't mind that answer myself. I think it might have to do with the fact that Point and Rectangle do not inherit from each other, and the data members are private, rather than protected, but I can't be sure. Hopefully some master class programmer will provide us with the answer.

It's a shame that we don't have any C++ers here.

You use initializer list when the private data members are
constant, have non-default constructors or are referances.

Can the Rectangle class call the Point classes constructor and pass it arguments, or do you have to use an assessor function like I did above. The classes do not inherit from each other. The assesor function worked, but I was getting errors when I tried to call the Point constructor. The original poster was getting errors as well. This is what we are trying to understand.

You can pass arguments to the constructor. I think the reason for the error is that he uses

Code:

---

Rectangle::Rectangle(int px,int py,int width,int height)
:x(px),y(py),m_width(width),m_height(height)
{}

---

when he wants

Code:

---

Rectangle::Rectangle(int px, int py, int width, int height)
 : x(px, py), y(px, py), m_width(width), m_height(height)
{

}

---

I'm not sure why the need for two points x and y.

You're right. Great. I had the syntax wrong when I tested it:

point.cpp file

Code:

---

#include"point.h"
#include<iostream>

int main()
{
  Rectangle rec(2,4,30,50);
  Rectangle rec2();

  return 0;
}

---

point.h file:

Code:

---

#ifndef _point_h
#define _point_h

class Point
{
 public:
  Point () { _x = 0; _y = 0; }
  Point(int x, int y) { _x = x; _y = y; }
  ~Point () { }

    private:
  int _x;
  int _y;
};

class Rectangle
{
 public:
  Rectangle() { _width = 0; _height = 0; }
  Rectangle (int, int, int, int);
  ~Rectangle() { }

 private:
  Point x;
  int _width;
  int _height;
};


Rectangle::Rectangle (int p1, int p2, int width, int height)
  :  _width(width), _height(height), x(p1,p2)
{
}

#endif

---