Thread: This never stops for some reason

This never breaks

Code:

#include <iostream>
#include <vector>
#include <stdlib.h>
#include <fstream>


using namespace std;

typedef vector<char*> CV;
CV CharacterVector;

ofstream fout;


int main(void) {
	fout.open("crap.db");

	int Number = 0;

	for( ; ; )  {{//stupid smily face arg

	CharacterVector.push_back(new char[50]);

	cout << "enter a character array "<< endl;

	cin.getline(CharacterVector[Number], 50);

	if(!atoi(CharacterVector[Number]) == 0) {

		cout << "You have chosen to quit" << endl;

		break;

	}
	else {
		fout << CharacterVector[Number] << endl;
		Number++;
	}
	}}

	fout.close();
	return 0;
}

My problem is with the atoi function, it never detects a '0' being entered.


This is kind of sad, I have been programming for a year now and I am still doing stupid stuff like this.

What are your opinions, do you think someone who has been programmign for a year should still be doing stupid stuff like this?

use tabs and ........ to make your code readable

First off:

for( ; ; ) {{ //<------- What the hell are two curly-braces doing here?
[...]
}} //<------- And the closing ones here?

It doesnt help that its very difficult to figure out whats inside what braces as you should indent a little differently (i.e. More).

if(!atoi(CharacterVector[Number]) == 0)

is possibly the strangest way i've ever seen this done. Why not:

if (atoi(CharacterVector[Number]) != 0) // ?

Also, if you're only checking a single character for a 0, why not just use the value of it? Try this:

Code:

int main(void)
{
	fout.open("crap.db");

	int Number = 0;

	for( ; ; )
	{
		CharacterVector.push_back(new char[50]);

		cout << "enter a character array "<< endl;
		cin.getline(CharacterVector[Number], 50);

		if (CharacterVector[Number] == 48) //48 is the ASCII value of 0. Alternately: if (CharacterVector[Number] == '0') would work
		{
			cout << "You have chosen to quit" << endl;
			break;
		}
		else
		{
			fout << CharacterVector[Number] << endl;
			Number++;
		}
	}

	fout.close();
	return 0;
}

Originally posted by Shadow12345
I don't see how it makes it harder to read
it's easier for me
that's why i do it

the mark of a novice programmer.


write logical, well-organized, well-commented code.

i'm not flaming you as a novice programmer; i am giving you a way to improve yourself!

Sorry, didnt notice that part.

try this:

if (CharacterVector[Number][0] == 48)

or this:

if (CharacterVector[Number][0] == '0')

instead. It will work.

Or, alternatly, your origional atoi test will work if you want to test the whole string, not just the first element. You just dont want the !.

if (atoi(CharacterVector[Number]) == 0)

strcmp would work too. strcmp returns 0 if the comparison is TRUE.

if (strcmp(CharacterVector[Number]), "0") == 0)

P.S. The indentation I used is much more readable to others. Obviously you do whatever you like best, its your code, but its a good habit to get into indenting like I posted.

/* Edit */
>>even though you said hell to me

Heh, sorry if that offended. Thats just me. Just trying to help.

Originally posted by Shadow12345

How long, in your opinion, do you have to be actively programmign in order to not be considered novice.

i think it's a stupid thing not worrying about. where do you draw the "novice" vs "non-novice" line? continue coding and you'll get better and better, simple as that. i'm not such a hot coder either , but i have one piece of advice for you: adopt an indentation scheme and use it as you write whenever you write. it really doesn't take longer to write, and it makes your code easier to read and dissect and debug in the future, and you might think "i'm only writing this 20 line program", but what if you decide to reuse the code in something larger or simply want to refer back to it later?

>>How long, in your opinion, do you have to be actively programmign in order to not be considered novice

Forever. Theres always someone better than you and always someone worse. I mean, I'm a 'newb' compared to the likes of adrianxw, sayeh, and the like, and yet I've been programming for about seven years.

The learning never stops.

/* Edit */

moi makes a good point, worth listening to. Indentation is one of the most simple things you can do that is so important.

Originally posted by Shadow12345
Yeah that makes sense. About the indentation scheme. I really like this scheme:

if(something == true) {
dosomething();
}

As opposed to

if(something == true)
{
dosomething();
}

both are good schemes; i use the former. just remember to indent dosomething(); in either case!!

but "{{" is not an indentation scheme