not all paths return a vale

hey all, my compiler says that not all these paths return a value, but to my eye they do. can someone help spot my error? thanks in advance :)

Code:

---

]
char Game::mf_game_displayOptions(int options)
{
        char choice='h';//local only
        if (options==1)
        {        bool choiceCheck=false;
                do
                {
               
                cout<<endl<<endl<<endl<<"count under con"<<"<B>unt, <L>eft grounder, <R>ight grounder, "
                        <<"<S>acrafice fly, <H>ome run"<<endl;
                cin>>choice;
                choice=tolower(choice);
                if (choice=='b' || choice=='l' || choice=='r'
                        || choice=='s' || choice=='h')
                {       
                        choiceCheck=true;
                        return choice;
                }
                else
                {       
                        clrscr();
                        cout<<"you've entered an invalid option, please change it.";
                        choiceCheck=false;
                }
                }while(choiceCheck==false);
        }
        else
        {return (choice);}

}

---

well technecilly your right but compilers can't read intentions, in essence to some compilers it would look like.

}while(choiceCheck==false);

if choiceCheck happens to go true before
choice equals one of these,

if (choice=='b' || choice=='l' || choice=='r'
|| choice=='s' || choice=='h')

there is no return. it doesn't always see that that is "technically" not possible.

so you have three options, get rid of the last else since all it does is return choice anyway, add a return at the end of the function, or ignore it.

Indeed, the last line of a function must álways return the right type, even when that's redundant.

Your inner if statement might be easier to read as a case statement.