Thread: Have a better method of doing this?

Code:

#include <iostream>
#include <fstream>

inline int some(int *a_number, int yournumber)
{
 a_number= new int[5];
 a_number[0]= yournumber;

 return a_number[0];
}

int main(int argc, char *argv[])
{
 int number;
 int extra;
 cout << "Input a number: ";
  cin >> number;

 extra= some(&extra, number);
 cout << "Your number is: " << extra << endl;

 cin.get();
 return 0;
}

I'm too depress to explain.

> I'm too depress to explain.

Well you'd better explain, because no one knows what the hell you're trying to do.

You can't just pass a single variable over (or rather, it's address) and treat it as an array of variables.

Oh, sure, you CAN, but this is what I like to call a BadThing(TM).

Quzah.

The Some function saves the user's keyboard input into a buffer(*a_number or &extra in main()). Its pretty simple really.

It leaks memory, and doesn't input multiple values (no need for buffer).

Code:

#include <iostream>
#include <vector>

int main() {
	std::vector<int> storage;
	int current;

	std::cout << "Enter sequence of numbers, enter a letter to quit " << std::endl;

	while (std::cin >> current) {
		storage.push_back(current);
	}

	std::cout << "Outputting with array notation"<< std::endl;
	for (size_t i = 0; i < storage.size(); i++) {
		std::cout << storage[i] << ' ';
	}

	std::cout << "\nOutputting with iterator notation" << std::endl;
	for (std::vector<int>::iterator it = storage.begin(); it != storage.end(); it++) {
		std::cout << *it << ' ';
	}

	return 0;
}

You need a using statement, like using namespace std;, or using std::cout;
Otherwise you have to do it SilentStrike's way of prefixing std:: to all your cout and cin and other library related statements. Maybe there's a reason to code that way, but I've never heard of it.