Whats wrong with my program?

The program's purpose is for the user to create a new file name along with the file extension.

Code:

#include <iostream>
#include <fstream.h>
#include <string>

void Stream(char &file, char &ext, ofstream &create)
{
 cout << "Type in a filename: ";
  cin >> file;
 cout << "\nType the file extension(ie: txt): ";
  cin >> ext;
 const char *filename=file + "." + ext;
 create.open(filename);
 create.close();
}

int main(int argc, char *argv[])
{
 char boob, lama;
 ofstream x;
 Stream(boob, lama, x);
 cout << "\nFile created was: " << boob << "." << lama << endl;

 cin.get();
 return 0;
}

ermmm...dont ya want - file + "." + ext
instead of - ext + "." + file

yeah, my fault. But besides that. It compiles well but it won't actually create the file.

I havent used C++ in years, dont you need to specify the entire path when creating and opening a file?

>But besides that. It compiles well...

More by luck than judgement, try something like -

Code:

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

void Stream(string &file, string &ext, ofstream &create)
{
 cout << "Type in a filename: ";
  cin >> file;
 cout << "\nType the file extension(ie: txt): ";
  cin >> ext;
 string filename=file + "." + ext;
 create.open(filename.c_str());
 create.close();
}

int main(int argc, char *argv[])
{
 string boob, lama;
 ofstream x;
 Stream(boob, lama, x);
 cout << "\nFile created was: " << boob << "." << lama << endl;

 cin.get();
 return 0;
}

Why not just...

Code:

#include <iostream.h>
#include <fstream.h>
#include <stdio.h>
#include <stdlib.h>

int main()
{
    char filename [15];
    
    cout<<"Enter file name and extension.\n";
    cin.getline (filename, 15);

    ofstream file (filename);
    
    file<<"This is a file";
    file.close();
  
    cout<<"File created was "<<filename<<".\n";
    system("pause");
    return 0;
}

The only difference here is the user will have to type the "." themselves...but that's not much of a problem is it?

Code:

#include //<iostream>
#include <fstream.h>
#include <string>

#define arraySize(x) sizeof(x)/sizeof(x[0])

void Stream(char &file, char &ext, ofstream &create)
{
 cout << "Type in a filename: ";
  cin >> file;
 cout << "\nType the file extension(ie: txt): ";
  cin >> ext;
 char *filename = new char[arraySize(file) + arraySize(ext)];
  strcat(filename, file);
  strcat(filename, '.');
  strcat(filename, ext);
 create.open(filename);
 create.close();
}

int main(int argc, char *argv[])
{
 char boob, lama;
 ofstream x;
 Stream(boob, lama, x);
 cout << "\nFile created was: " << boob << "." << lama << endl;

 cin.get();
 return 0;
}

I'm pretty sure filename can't be constant... as it's created dynamically. Also, you were adding "." to a char, not only can't you use the + operator on chars, it would be '.' and not "."

Ah well, hope this helps.
Edit:: I'm pretty sure iostream.h is included in fstream.h, so you don't need to include the iostream header.

I like Sorensen's version a little better. I hate using chars, but I got a compiling error early that says you cannot use strings in iostream:pen( );