Thread: Can't figure out strcmp error

I've searched the board and the books and can not figure out why I can not compare the value of two string objects in my 2D array. Here's the code...

Code:

if(strcmp(*p2EmpInfo[a][e], *p2EmpInfo[a-1][e]) > 0)
			{
				string temp;
				*p2EmpInfo[a][e] = temp;
				*p2EmpInfo[a-1][e] = *p2EmpInfo[a][e];
				temp = *p2EmpInfo[a-1][e];
			}

I have tried to cast it as a char variable....used a str1<str2? type comparison and also chanted in Swahili while letting the blood of a 2 month old chicken onto a plate with the bones of a sparrow, all to no avail. Where am I going wrong? Is it the logic? Do I need a younger chicken?

I can get the program to execute, but when it gets to the sorting section (I just kept it in main()...), it encounters an error and the program bails on me.

If you are using #include <string> and string objects in your code then you should just be able to use the boolean operators >, <, ==, etc to do comparisons, these operators are overloaded for this type of object. strcmp is for character arrays/pointers.

That would explain the error messages, I have included the <string> header. Would including the <string.h> nullify the ability to use these operators?

By the way, thank you for the prompt reply to my initial question.

Yeah, you can use a 2d array for strings, but sorting it seems to be a pain in the rectum. The first position is more of an index, the second part is the name/social-security-number portion. It's easier to display it after the sort....Should I ever have success with it.

Are you just trying to sort an array of strings? Are you familiar with any of this?:

Code:

#include <string>
#include <vector>
#include <algorithm>
#include <iostream>

using namespace std;

int main()
{
    vector<string> array;
    vector<string>::iterator itArray;
    array.push_back( "Mike" );
    array.push_back( "Andrew" );
    array.push_back( "Smith" );
    array.push_back( "Barry" );
    array.push_back( "John" );
    array.push_back( "Larry" );
    cout << "Unsorted list:" << endl;
    for( itArray = array.begin(); itArray != array.end(); itArray++ )
        cout << *itArray << endl;
    sort( array.begin(), array.end() );
    cout << "Sorted list:" << endl;
    for( itArray = array.begin(); itArray != array.end(); itArray++ )
        cout << *itArray << endl;
    return 0;
}

On my computer this gives the following:

Unsorted list:
Mike
Andrew
Smith
Barry
John
Larry
Sorted list:
Andrew
Barry
John
Larry
Mike
Smith

I quote some of your code and I edit it

Code:

 string x = *p2EmpInfo[a][e];
 string y = *p2EmpInfo[a-1][e]; 
 if(strcmp(x,y) > 0){
   /* string temp;
   *p2EmpInfo[a][e] = temp;
   *p2EmpInfo[a-1][e] = *p2EmpInfo[a][e];
   temp = *p2EmpInfo[a-1][e];
   */
  // ARE YOU SWAPING THEM ... IF TRUE YOU SHOULD DO THIS
 
  temp = x;
  x = y;
  y= temp ;

 } // this should work Else YOU HAVE A RPOBLEM WITH YOUR ARRAY

strcmp is for comparing char arrays. It is not compatible with class string!!! Look at the post by " hk_mp5kpdw". This is the correct way. (Unless of course you feel like overloading strcmp???)

Could he overload Strcomp function... ?

Thanks a lot for all the help, I used the syntax used by Nano and it worked perfectly. The concept was where I was falling apart, but it's working perfectly now....Man, I'm feeling all warm and fuzzy inside.....