Thread: Enter and write out words into a tree of nodes

Originally Posted by Salem

Post your latest code for addNode

Code:

...
Tnode* Tree::addNode(Tnode* root, string word)
{
        Tnode* node;
        if (!root)
        {
                node = new Tnode;
                size_t copyLen = std::min(sizeof(node->word)-1, word.size());
                strncpy(node->word, word.c_str(), word.size()-1);
                node->word[copyLen] = '\0';
                node->left = 0;
                node->right = 0;
                node->count = 1;
                return (node);
        }

        int cmp = strcmp(word.c_str(), root->word);
        if (cmp < 0)
        {
                node = addNode(root->left, word);
                if(!root->left)
                {
                        root->left = node;
                }
        }
        else if (cmp > 0)
        {
                node = addNode(root->right, word);
                if(!root->right)
                {
                        root->right = node;
                }
        }
        else
        {
                root->count++;
        }
        return (node);
}

...

Originally Posted by Salem

> strncpy(node->word, word.c_str(), word.size()-1);
You really need to learn how to copy/paste better.

Seriously.
strncpy(node->word, word.c_str(), copyLen);

I am very sorry. Please sorry.My fault.

Originally Posted by Salem

> strncpy(node->word, word.c_str(), word.size()-1);
You really need to learn how to copy/paste better.

Seriously.
strncpy(node->word, word.c_str(), copyLen);

It works now, thank you very much. May I ask you a last question regarding this code?

Originally Posted by Salem

> strncpy(node->word, word.c_str(), word.size()-1);
You really need to learn how to copy/paste better.

Seriously.
strncpy(node->word, word.c_str(), copyLen);

I have implemented following to get an output if new allocation is not possible:

Code:

...
Tnode* Tree::addNode(Tnode* root, string word)
{
        Tnode* node;
        if (!root)
        {
                node = new(nothrow) Tnode;
                if(node == 0)
                {
                        cout << "Allocation returned nullptr\n" << endl;
                        exit(1);
                }
                size_t copyLen = min(sizeof(node->word)-1, word.size());
                strncpy(node->word, word.c_str(), copyLen);
                node->word[copyLen] = '\0';
                node->left = 0;
                node->right = 0;
                node->count = 1;
                return (node);
...

Is that correct? And how can I insert more info in it like how much memory should be requested or for which object of which class was it requested.. Something like that.

I will also replace class 'string' with word <directly> as "const char*", but I am not sure how.Could someone advise please?

Originally Posted by Joe1903

I have implemented following to get an output if new allocation is not possible:

Code:

...
Tnode* Tree::addNode(Tnode* root, string word)
{
        Tnode* node;
        if (!root)
        {
                node = new(nothrow) Tnode;
                if(node == 0)
                {
                        cout << "Allocation returned nullptr\n" << endl;
                        exit(1);
                }
                size_t copyLen = min(sizeof(node->word)-1, word.size());
                strncpy(node->word, word.c_str(), copyLen);
                node->word[copyLen] = '\0';
                node->left = 0;
                node->right = 0;
                node->count = 1;
                return (node);
...

Is that correct? And how can I insert more info in it like how much memory should be requested or for which object of which class was it requested.. Something like that.

Can anyone advise?

Originally Posted by Salem

What do you want to know?

Are you suggesting that if you have a very long string that you spread it over several nodes?

It's certainly possible, but you need to add further information to indicate that any particular node holds a complete string or a fragment.

Also, calling exit is brutal.
Pass NULL back to the caller, so a more appropriate error handling approach can be attempted.

What I actually want to do is if there is no memory available for new[] it should write out a message like there is no space available with some additional info like e.g. how much memory is available currently.

Originally Posted by Salem

To be honest, in a C++ program, you shouldn't be using the (nothrow) unless you really have a good plan B to deal with the out of memory.
Even if you do have a good plan B at this point in the program, using the C++ try/catch mechanism is the way to deal with it.

Otherwise, let the system propagate std::bad_alloc to a point where the program can deal with it sensibly.

For example, if you were writing a text editor, your user would be royally p***ed if the program just aborted because some edit operation failed. In this case, the exception needs to be caught before the whole program exits, and some effort needs to be made to save the current work to a recovery file.

There is no good (that is portable) way to determine how much memory is available to a program. It might not even be a static value. For example, the more programs a system has running, the less real + swap memory there is to go around. Also, a single large block might fail where a greater amount of smaller blocks might succeed.

Could you please give me an example with try-catch?

Originally Posted by Salem

Well no, because you carry on and do what you were going to do anyway, having caught and subsequently ignored the meaning of the exception.

The exception handler happens in main, where it says "your list is full, what do you want to do now".

Ok I will read the chapter again now.
Another question: I want to replace class 'string' with word <directly> as const char*.But I am not sure how.Could you please advice?