Thread: Creating a program which accepts 10 numbers & then displays them in descending order

You might have a font problem rather than a programming problem. Look carefully:

Code:

for(i=0;1<=9;i++)

The loop condition is 1<=9, i.e., "one less than or equal to nine", but you probably wanted it to be i<=9, i.e., "value of i less than or equal to nine".

By the way, instead of using i <= 9, I suggest i <= 10. You can then declare a named constant for the array size, and then use that instead of the magic number 10.

Also, I recommend consistently indenting with 2 to 8 spaces or one tab character per indent level. My preference is 4 spaces, so:

Code:

#include <iostream>
#include <algorithm>

using namespace std;

int main()
{
    int numb[10];
    int i, j;

    for (i = 0; 1 <= 9; i++)
    {
        cout <<"Please enter numer: ";
        cin >> numb[i];
    }

    for (i = 0; i <= 8; i++)
    {
        for (j = i + 1; j <= 8; j++)
        {
            int temp;
            if (numb[i] < numb[j])
            {
                temp = numb[i];
                numb[i] = numb[j];
                numb[j] = temp;
            }
        }
    }

    for (i = 0; i <= 9; i++)
    {
        cout << endl << numb[i] << endl;
        system("pause");
        return 0;
    }
}

With proper indentation another bug becomes evident: you place the return 0; (and perhaps the call to system) at a wrong place. Note that as a special case for the global main function, you don't actually need this return 0; as when control reaches the end of the main function, it will be as if you wrote return 0; there.

Another thing to note: while you arguably don't need and should not use system("pause") here, if you do want to call the system function, you should #include <cstdlib>.

Originally Posted by laserlight

By the way, instead of using i <= 9, I suggest i <= 10. You can then declare a named constant for the array size, and then use that instead of the magic number 10.

TYPO Alert: You likely meant "instead of using i <= 9, I suggest i < 10."

Tim S.