Thread: stack overflow?

I have a function with 55 arguments. I don't think anything is wrong with the syntax, there are no compile errors, but when the program starts i get the windows has encountered an error crap and my program closes. i go to debug and it says somehting like stack overflow. is there a limit to how many arguments?

can i try and help post your code

I have a function with 55 arguments. I don't think anything is wrong with the syntax, there are no compile errors, but when the program starts i get the windows has encountered an error crap and my program closes. i go to debug and it says somehting like stack overflow. is there a limit to how many arguments?

55? Is it just me or is that way too many arguments for one function? I think you should try grouping some of the parameters into a struct, or splitting the function up into smaller, more specialized functions.

http://www.google.com/search?q=stack+overflow

all of the variables im passing are of the same type, which is from a struct. so i couldnt put them all into one struct

Way too many arguments
The amount of stack space depends on
- Your OS
- Your compiler
- Your compiler options
- probably some other stuff as well.


If you're trying to pass all the members of a structure like
func( foo.a, foo.b );

Consider for brevity of typing
func ( foo );

And to save lots of space
func ( &foo ); // pointer to foo

first of all, that is a reference to foo, not a pointer to foo. second of all, i know that! let me explain:

here is what my code is like:

Code:

struct ROOM
{
    ROOM* north;
    ROOM* west;
    ROOM* east;
    ROOM* south;
    //...etc
};

//now i declare 55 variables of type ROOM:
ROOM room1;
ROOM room2;
ROOM room3;
ROOM room4;
//....etc until room55

//now this is how i pass the variables:
void func(ROOM& room1, ROOM& room2, ROOM& room3)//...til 55

are you saying that i can pass all the variables of type room by doing something like passing ROOM when called in main, and use &ROOM for the prototype and definition? so....:

Code:

void func(&ROOM); //prototype

//in main
func(ROOM);

//definition
void func(&ROOM)
{
    //blah blah, being able to use all 55 of my 'ROOM's?
}

is that possible?

//....etc until room55

Perhaps an array then
ROOM rooms[55];

Then
void func ( ROOM rooms[] );


Which would be called
func ( rooms );

...ok that last option i said above is not possible....

i only use the function for more organization, i set all the attributes for each 'ROOM' in the function, thats all. i COULD do it all outside a fuction, it would be THAT much of a sacrifice, but do you guys get the situation now?

I say go with the Array of Rooms.

since you already pass by reference, so far so good........

you must know that if you "pass" something to a function even by reference it is still put on the stack, althought in case of "reference" the only thing that is put on the stack is a pointer..

here's a suggestion: use a POINTER POINTER to a struct......

no it is not a typo error --- it's a double pointer......you can pass a pointer to all the existing pointers, which makes the stack a lot smaller....

you can accomplish this by for example putting all your pointers into an array, and thus pass an array name, which is just a "tag name pointer", to a function.........

hope this helps,

Regards,
matheo917