Thread: Array output

I have a program where the user enters some numbers, and those numbers are outputted again, along with (input number) number of # signs on each line. I have the output, but I need some help for the rest.
For example, input 1 2 3 should be this:

Code:

Number of values to graph: 3
1 2 3

 1 | #
 2 | ##
 3 | ###

but instead it's:

Code:

Number of values to graph: 3
1
2
3
1
 2
 3

How do I get from the second one to the top one?
My code is:

Code:

#include <iostream>
#include <iomanip>
using namespace std;
int main( ) {
    int numbers[10];
    int howmany;
    cout << "Number of values to graph: ";
    cin >> howmany;
    for( int i = 0; i < howmany; i++ )
    {
        cin >> numbers[i];
    }
    if( howmany <= 0 )
        cout << "No numbers entered." << endl;
    else
    {
        cout << numbers[0];
        for( int x = 1; x < howmany; x++ )
            cout << setw(2) << endl << numbers[x];
        cout << endl;
    }
}

Originally Posted by Kelton2

How do I get from the second one to the top one?
My code is:

Code:

#include <iostream>
#include <iomanip>
using namespace std;
int main( ) {
    int numbers[10];
    int howmany;
    cout << "Number of values to graph: ";
    cin >> howmany;
    for( int i = 0; i < howmany; i++ )
    {
        cin >> numbers[i];
    }
    if( howmany <= 0 )
        cout << "No numbers entered." << endl;
    else
    {
        cout << numbers[0];
        for( int x = 1; x < howmany; x++ )
            cout << setw(2) << endl << numbers[x];
        cout << endl;
    }
}

Use std::vector instead of that array.
Don't use "howmany"; instead, get the numbers from the user until they don't give any more.

Your loop (which I have highlighted) starts at 1, it should start at 0. And the call before it should not be there. I have no idea why you did that.

OK, fixed the loop. I have to use the array though.

I'd also recommend doing a quick check to assure that the howmany is also less than or equal to 10. You want a number between 1 and 10 but as of now, you just check if it's zero or negative.

No, it's actually a check for 40, not 10. I'll add that though.

Originally Posted by Kelton2

No, it's actually a check for 40, not 10. I'll add that though.

Okay. I was jsut going by:

Code:

    int numbers[10];
    int howmany;
    cout << "Number of values to graph: ";
    cin >> howmany;
    for( int i = 0; i < howmany; i++ )
    {
        cin >> numbers[i];
    }

Regardless, it'd best if you rewrote your code like this :

Code:

const int size = 40;

int numbers[size] = { 0 };
int how_many = 0;

std::cin >> how_many;

if (how_many <= 0 || how_many > size)
{
    /* handle error */
}

Originally Posted by Kelton2

OK, fixed the loop. I have to use the array though.

No you don't.

If you really need access to contigious data, std::vector manages an array underneath that you can access with &x[0].

Otherwise, if your teacher tells you that you must use an array, he/she is a horrible teacher.