Thread: C/C++ code

Originally Posted by tarnold79

C/C++ code

There is a programming language named C. There is a programming language named C++. There is no programming language named C/C++. So, you need to be clear as to whether your code is C or C++. You can write code that is intended to be compilable on both C and C++ compilers, but that is not "C/C++" either.

Originally Posted by tarnold79

I have the following code below

You need to format your code properly, especially where indentation is concerned. For example:

Code:

char nott(char operand);
char andd(char operand1, char operand2);
char orr(char operand1, char operand2);
char xorr(char operand1, char operand2);

#define PREFERRED 'p'
#define OTHER 'o'
#define INVALID 'x'

char nott(char operand)
{
    char result = INVALID;
    if (operand == PREFERRED)
        result = OTHER;
    else
        result = PREFERRED;
    return (result);
}

char andd(char operand1, char operand2)
{
    char result = INVALID;
    if (operand1 == PREFERRED)
    {
        if (operand2 == PREFERRED)
        {
            result = PREFERRED;
        }
        else if (operand2 == OTHER)
        {
            result = OTHER;
        }
    }
    else if (operand1 == OTHER)
    {
        if (operand2 == OTHER)
        {
            result = OTHER;
        }
        else if (operand2 == PREFERRED)
        {
            result = OTHER;
        }
    }
    return (result);
}

char orr(char operand1, char operand2)
{
    char result = 0;
    result = INVALID;
    if (operand1 == PREFERRED)
        result = PREFERRED;
    else if (operand2 == PREFERRED)
        result = PREFERRED;
    else
        result = OTHER;
    return (result);
}

char xorr(char operand1, char operand2)
{
    char result = orr(andd(nott(operand1), operand2), andd(nott(operand2), operand1));
    return (result);
}

char nandd(char operand1,char operand2)
{
    char result = INVALID;
    result = nott(andd(operand1, operand2));
    return (result);
}

I suggest that you use braces for if statements even when it is unnecessary. You have done this inconsistently in your code.

Originally Posted by tarnold79

i am trying to add xnorr,norr,nandd function to it

You need to be clear as to what these functions do, and hence you need to tell us what they do, rather than assume that we know based on their names (and perhaps we do know, but what we know doesn't match what you think they should be). It would also be a good idea to document your existing functions (e.g., using comments) to describe what they do (but you don't need to explain how they do what they do, except where the implementation of the code needs some explanation).

Code:

return (result);

Does anyone remember which Language required or was better with the () in the return statement?

I remember doing this a many years ago; because it was needed in one of my very earlier programming languages and I forgot what it was.

Tim S.

Originally Posted by stahta01

Code:

return (result);

Does anyone remember which Language required or was better with the () in the return statement?

I remember doing this a many years ago; because it was needed in one of my very earlier programming languages and I forgot what it was.

Tim S.

Question 20.19

Does anyone remember which Language required or was better with the () in the return statement?

I don't remember if it was required or not, but I think it is a hold over from K+R C. Many of the examples, that actually return a value, used the parentheses. For example from this link: Programming in C: A Tutorial Brian W. Kernighan Bell Laboratories, Murray Hill, N. J.

14. Functions; Comments

...

We have already seen many examples of calling a function, so let us concentrate on how to define one. Since count has two arguments, we need to declare them, as shown, giving their types, and in the case of buf, the fact that it is an array. The declarations of arguments go between the argument list and the opening `{'. There is no need to specify the size of the array buf, for it is defined outside of count.

The return statement simply says to go back to the calling routine. In fact, we could have omitted it, since a return is implied at the end of a function.

What if we wanted count to return a value, say the number of characters read? The return statement allows for this too:

Code:

               int i, c, nchar;
               nchar = 0;
               ...
               while( (c=getchar( )) != '\0' ) {
                       if( c > size || c < 0 )
                               c = size;
                       buf[c]++;
                       nchar++;
               }
               return(nchar);

Any expression can appear within the parentheses. Here is a function to compute the minimum of two integers:

Code:

       min(a, b)
          int a, b; {
               return( a < b ? a : b );
       }

Jim