Thread: im stuck: void getscore should read from a file

I also recommend you read the documentation for your compiler and increase the warning levels. Look at the warnings I get when I compile your code.

main.cpp||In function ‘int main()’:|
main.cpp|22|warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]|
main.cpp|25|warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]|
main.cpp|28|warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]|
main.cpp|31|warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]|
main.cpp|64|warning: unused parameter ‘s2’ [-Wunused-parameter]|
main.cpp|64|warning: unused parameter ‘s3’ [-Wunused-parameter]|
main.cpp|64|warning: unused parameter ‘s4’ [-Wunused-parameter]|
main.cpp|64|warning: unused parameter ‘s5’ [-Wunused-parameter]|

Jim

Code:

#include <iostream>
#include <iomanip>
#include <fstream>
using namespace std;

void getScore(int& score, ifstream& inFile);
void calcAverage(int testSc1, int testScr2, int testScr3, int testScr4, int testScr5);
int findLowest(int testScr1, int testScr2, int testScr3, int testScr4, int testScr5);
int lowest = 100;
int testScr1, testScr2, testScr3, testScr4, testScr5;

int main()
{
    ifstream inFile;
    inFile.open("grades.txt");

    getScore(testScr1,inFile);
    if (testScr1 = lowest)
    {
     lowest = testScr1;
    }
    getScore(testScr2,inFile);
    if (testScr2 > testScr1)
    {
        lowest = testScr2;
    }
    getScore(testScr3,inFile);
    if (testScr3 > testScr2)
    {
        lowest = testScr3;
    }
    getScore(testScr4,inFile);
    if (testScr4 > testScr3)
    {
        lowest = testScr4;
    }
    getScore(testScr5,inFile);
    if (testScr5 > testScr4)
    {
        lowest = testScr5;
    }

        calcAverage(testScr1, testScr2, testScr3, testScr4, testScr5);

        inFile.close();

    return 0;
}

void getScore(int& score, ifstream& inFile)
{

    inFile >> score;




    void calcAverage(int testScr1, int testScr2, int testScr3, int testScr4, int testScr5);
    int sum;
    int lowest;
    double average;


    lowest = findLowest(testScr1, testScr2, testScr3, testScr4, testScr5);

    sum = testScr1 + testScr2 + testScr3 + testScr4 + testScr5 - lowest;
    average = sum / 4.0;

    cout << setw(4) << fixed << showpoint << setprecision(2);
    cout << "The avergae of the four highest scores are: " << average << endl;


    int findlowest(int testScr1, int testscr2, int testScr3, int testScr4, int testScr5);


    int lowest;
    
    cout << "The lowest test score is: " << lowest << endl;

    return lowest;
}

errors:Error 1 error C2086: 'int lowest' : redefinition c:\users\james\documents\visual studio 2013\projects\test2\test2\test2.cpp 76 1 test2
Error 2 error C2562: 'getScore' : 'void' function returning a value c:\users\james\documents\visual studio 2013\projects\test2\test2\test2.cpp 80 1 test2
3 IntelliSense: return value type does not match the function type c:\Users\JAMES\Documents\Visual Studio 2013\Projects\test2\test2\test2.cpp 80 9 test2


I am having a hard time understanding what the errors mean.. I have made changes and every time I make changes I get new errors.

Code:

#include <iostream>
#include <iomanip>
#include <fstream>
using namespace std;

void getScore(int& score, ifstream& inFile);
void calcAverage(int testSc1, int testScr2, int testScr3, int testScr4, int testScr5);
int findLowest(int testScr1, int testScr2, int testScr3, int testScr4, int testScr5);
int lowest = 100;
int testScr1, testScr2, testScr3, testScr4, testScr5;

int main()
{
    ifstream inFile;
    inFile.open("grades.txt");

    getScore(testScr1, inFile);
    lowest = testScr1;
    getScore(testScr2, inFile);
    if (lowest > testScr2);
    lowest = testScr2;
    getScore(testScr3, inFile);
    if (lowest > testScr3);
    lowest = testScr3;
    getScore(testScr4, inFile);
    if (lowest > testScr4);
    lowest = testScr4;
    getScore(testScr5, inFile);
    if (lowest > testScr5);
    lowest = testScr5;


        calcAverage(testScr1, testScr2, testScr3, testScr4, testScr5);

        inFile.close();

    return 0;
}

void getScore(int& score, ifstream& inFile)
{

    inFile >> score;




    void calcAverage(int testScr1, int testScr2, int testScr3, int testScr4, int testScr5);
    int sum;
    int lowest;
    double average;


    lowest = findLowest(testScr1, testScr2, testScr3, testScr4, testScr5);

    sum = testScr1 + testScr2 + testScr3 + testScr4 + testScr5 - lowest;
    average = sum / 4.0;

    cout << setw(4) << fixed << showpoint << setprecision(2);
    cout << "The avergae of the four highest scores are: " << average << endl;


    int findlowest(int testScr1, int testscr2, int testScr3, int testScr4, int testScr5);


    int lowest;
    
    cout << "The lowest test score is: " << lowest << endl;

    return lowest;
}

changed some things again cause I figured out that is not right for if statement..
this is what I get in return:
Warning 1 warning C4390: ';' : empty controlled statement found; is this the intent? c:\users\james\documents\visual studio 2013\projects\test2\test2\test2.cpp 21 1 test2
Warning 2 warning C4390: ';' : empty controlled statement found; is this the intent? c:\users\james\documents\visual studio 2013\projects\test2\test2\test2.cpp 24 1 test2
Warning 3 warning C4390: ';' : empty controlled statement found; is this the intent? c:\users\james\documents\visual studio 2013\projects\test2\test2\test2.cpp 27 1 test2
Warning 4 warning C4390: ';' : empty controlled statement found; is this the intent? c:\users\james\documents\visual studio 2013\projects\test2\test2\test2.cpp 30 1 test2
Error 5 error C2086: 'int lowest' : redefinition c:\users\james\documents\visual studio 2013\projects\test2\test2\test2.cpp 66 1 test2
Error 6 error C2562: 'getScore' : 'void' function returning a value c:\users\james\documents\visual studio 2013\projects\test2\test2\test2.cpp 70 1 test2
7 IntelliSense: return value type does not match the function type c:\Users\JAMES\Documents\Visual Studio 2013\Projects\test2\test2\test2.cpp 70 9 test2

Look at each line mentioned in your warning messages, look for "extra" things like semicolons.

For the first error message, why are you prototyping a function inside your function?

For the second error read the message carefully, it tells you exactly what is wrong.


And most importantly stop throwing code at the problem with hopes of it fixing the problem. You need to think about what is the problem before you even sit down at the computer to write the first line of code.


Jim

Code:

#include <iostream>
#include <iomanip>
#include <fstream>
using namespace std;

// Function prototype
void getScore(int& score, ifstream& inFile);
void calcAverage(int s1, int s2, int s3, int s4, int s5, int lowest);
int findLowest(int, int, int, int, int);
int grades(int, int, int, int, int);
int main()
{
    ifstream inFile;
    inFile.open("grades.txt");
    int lowest;
    int testScr1, testScr2, testScr3, testScr4, testScr5;

    // I deleted all the semicolons after if()
    // Semicolons after if() are a bad idea; they make the comparison meaningless because a semicolon is a complete statement that means do nothing.
    // So the if() will do nothing and then run whatever was underneath.
    getScore(testScr1, inFile);
    lowest = testScr1;
    getScore(testScr2, inFile);
    if (lowest > testScr2)
        lowest = testScr2;
    getScore(testScr3, inFile);
    if (lowest > testScr3)
        lowest = testScr3;
    getScore(testScr4, inFile);
    if (lowest > testScr4)
        lowest = testScr4;
    getScore(testScr5, inFile);
    if (lowest > testScr5)
        lowest = testScr5;

    calcAverage(testScr1, testScr2, testScr3, testScr4, testScr5, lowest);

    inFile.close();

    return 0;
}

void getScore(int& score, ifstream& inFile)
{

    inFile >> score;
}


void calcAverage(int s1, int s2, int s3, int s4, int s5, int lowest)
{
    int sum;
    
    double average;

    
    sum = s1 + s2 + s3 + s4 + s5 - lowest;
    average = sum / 4.0;

    cout << setw(4) << fixed << showpoint << setprecision(2);
    cout << "The avergae of the four highest scores are: " << average << endl;
}

int findLowest(int s1, int s2, int s3, int s4, int s5)
{
    int lowest = s1;

    cout << "The lowest test score is: " << lowest << endl;

    return lowest;
}

OK..had to change a few things.. I did and it currently giving the correct average of the 4 highest score (leaving out the lowest score) but now it does not read out the lowest score at all. I tried to change things a little to fix that only to get back where I was which was reading out the top score wo I went back and this is where I am. I am sure that it is an easy fix but im not seeing it.

What do you mean it doesn't read the lower score. It reads all five scores, finds and subtracts the lowest score then computes and prints the average of these highest four scores.

If you mean it is not printing the lowest score, that is because you never actually print that value.

Jim

No it prints the average and its correct so thats good.. I thought I was asking it to print the average at the bottom:

Code:

int findLowest(int s1, int s2, int s3, int s4, int s5)

{

    int lowest = s1;

 

    cout << "The lowest test score is: " << lowest << endl;

 

    return lowest;
}

If you mean you want to print the lowest score, you should write a cout statement near the bottom of calcAverage(), or near the bottom of main(). Like I said before, you can delete the findLowest() function as it will never be called.