Thread: Rock Paper Scissor HW Lab Code

Please post the code as text, between code tags. We can't compile a picture.

Jim

Code:

 #include <iostream>
#include <cstdlib>


using namespace std;


int main ()
{


    // Declare the Variables //
    
    string player1;
    string player2;
    string r;
    string p;
    string s;
    
    // Input the rules of Paper, Scissor, Rock //
    
    cout << "player1: Enter r for rock, p for paper, or s for scissors:";
    cin >> player1;
    cout << "player2: Enter r for rock, p for paper, or s for scissors:";
    cin >> player2;
    
    
    if (player1 == player2)
    {
        cout <<"There is a tie" <<endl;
    }
    
    if ( player1 == r && player2 == p)
    {
        cout << "Paper wraps rock, Player1 win";
    }
    else if (player1 == r && player2 == s)
    {
        cout << "Rock smashes scissors, player1 win";
    }
    
    if (player1 == p && player2 == r)
    {
        cout <<"Paper wraps rock, player1 win";
    }
    else if ( player1 == p && player2 == s)
    {
        cout <<"Scissors cut paper, player2 win";
    }
    
    if ( player1 == r && player2 == p)
    {
        cout << "Paper wraps rock, Player1 win";
    }
    else if (player1 == r && player2 == s)
    {
        cout << "Rock smashes scissors, player1 win";
    }
    
    if (player1 == p && player2 == r)
    {
        cout <<"Paper wraps rock, player1 win";
    }
    else if ( player1 == p && player2 == s)
    {
        cout <<"Scissors cut paper, player2 win";
    }
    
    if ( player2 == s && player1 == r)
    {
        cout <<"Scissors cut paper, player1 win";
    }
    else if (player2 == s && player1 == p)
    {
        cout <<"Rock smashes scissors, player2 win ";
    } 
    
    return 0;
}

Sorry but here it is! sorry new to this place lol

You seem to be using the names of variables like they were values. You really should be using a constant in your comparisons.

Since you're using strings something like:

Code:

  if ( player1[0] == 'r' && player2 == "p")

Note the difference between player1 and player two. With player1 I'm comparing just the first letter to the character constant 'r'. With player2 I'm comparing the whole word to the string constant "p".

Also don't forget that C/C++ is case sensitive and single quotes denote a char and double quotes denote a string, 's' is not the same as 'S' or "s" or "S".

Jim

OH MY GOD! this works!!! Thank you So Much! it now displays the rules and everything!

Originally Posted by Elysia

chars are bad since they leave the newlines in the input buffer.
However, I would agree that std::getline would be better since it will read everything the user has entered so far, so you won't get surprises later.

Yes, that's why I like getline(), but he could compare using chars instead of strings too either way.

chars are bad since they leave the newlines in the input buffer.

The extraction operator leaves newlines in the input buffer, though It doesn't really matter what you read - newlines count as white space, and the extraction operator skips white space by default.

For a program like this I would getline() to get the input, then use either toupper() or tolower() on the first character of the string and compare that character to a constant char of the proper case. I try to avoid actually comparing strings entered by the user unless absolutely necessary. Users can be very unpredictable, and simple spelling errors, and capitalization issues are very hard to predict. But "usually" they can at least get the first letter correct (if you eliminate capitalization issues). Even if you tell them to enter a single character many times they will enter more than that single character, for example typing out "paper" instead.

and the extraction operator skips white space by default.

Unless you're retrieving a char, which by default the extraction operator doesn't skip leading ws.

Jim

Originally Posted by jimblumberg

Unless you're retrieving a char, which by default the extraction operator doesn't skip leading ws.

Jim

Doesn't seem to be true:

Code:

Josh2@Josh-PC /cygdrive/c/users/josh2/desktop
$ cat foo.cpp
#include <iostream>
#include <sstream>
#include <string>

int main()
{
    std::string s = "\nreally?";
    std::istringstream input(s);
    char newlineMaybe;
    input >> newlineMaybe;
    std::cout<<newlineMaybe<<" "<<std::hex<<int(newlineMaybe)<<std::endl;
}

Josh2@Josh-PC /cygdrive/c/users/josh2/desktop
$ ./foo
r 72