Thread: Load Strings into Vectors From a File

Okay, so I'm working on a project, and I'm trying to fill in various vectors from a given input file. The input file looks like:
<catalog>
<book id ="bk101">
<author>O'Brien, Tim</author> ....etc
My load vectors function looks like this: void load_vectors(vector<string>&id, vector<string>& author...etc)

I can't assume a limit on the number of books etc listed in this catalog, so I'm using the eof() function. However, I don't know how to write the loop to gather the correct strings and place them in the vectors.

Code:

while(in.eof())
{ string text;
int index, index2;

getline(in, text);
int index = text.find("<author>");
int index2 = text.find("</author>");
a = index.lenght();
author.pushback[i] = text.substr(index + a, index2);
}

Thank you for any feedback. Example codes would be extremely helpful.

Originally Posted by Ralek

Code:

while(in.eof())
{ string text;
int index, index2;

getline(in, text);
int index = text.find("<author>");
int index2 = text.find("</author>");
a = index.lenght();
author.pushback[i] = text.substr(index + a, index2);
}

*) You declare index and index2 twice.
*) Suppose to be "length", not "lenght".
*) "index" is an integer. Why are you calling length on an integer?
*) Suppose to be push_back(), not pushback[i]. What does "i" even mean?
*) Using "getline" for this won't work very well if the <author/> tags aren't on the same line.
*) substr()'s second argument is length, not an offset.
*) What the hell are you doing?

Sorry, lol. Everything you said is actually fixed in my code, but I typed this out here just for the concept. I didnt actually mean for that to be my code. I'm just confused on where to put a loop.

Originally Posted by Ralek

Sorry, lol. Everything you said is actually fixed in my code, but I typed this out here just for the concept. I didnt actually mean for that to be my code. I'm just confused on where to put a loop.

Ah, kk. Post your (non-)working code! Someone/I will be able to tell you why it's not working, and where you should go from there.